| Summary: | Inline editing is broken | ||
|---|---|---|---|
| Product: | [Applications] NeoChat | Reporter: | Nate Graham <nate> |
| Component: | General | Assignee: | Tobias Fella <fella> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | carl, james.h.graham, nicolas.fella |
| Priority: | NOR | Keywords: | regression |
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/network/neochat/commit/2dd3197beb13596162a4f8559405e430dd2cc14f | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | It broke | ||
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/803 *** Bug 466043 has been marked as a duplicate of this bug. *** Git commit 2dd3197beb13596162a4f8559405e430dd2cc14f by James Graham. Committed on 20/02/2023 at 18:24. Pushed by nvrwhere into branch 'master'. Inline Edit Fixes - Make sure the connection to the room's chatBoxEditIdChanged signal is made so that the edit box gets filled. - Make sure the minimum height and preferred width are available to the loader so they can be set and dynamically updated. M +3 -0 src/qml/Component/Timeline/MessageDelegate.qml M +15 -16 src/qml/Component/Timeline/MessageEditComponent.qml https://invent.kde.org/network/neochat/commit/2dd3197beb13596162a4f8559405e430dd2cc14f |
Created attachment 156375 [details] It broke Clicking on the edit button shows an empty text field. See screen recording, and apologies for the potato-quality video. Regression from f785e4d5b0e77f3e28fdfc5891bb6f9b0e562649.