| Summary: | Inconsistent look and feel "OK / Cancel" order | ||
|---|---|---|---|
| Product: | [Plasma] KScreen | Reporter: | dft <dieseltrike> |
| Component: | common | Assignee: | kscreen-bugs-null <kscreen-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | nate |
| Priority: | NOR | ||
| Version First Reported In: | 5.27.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kscreen/commit/06f0671a8337a1c51cc6d6b29c3b1d258c311119 | Version Fixed/Implemented In: | 5.27.1 |
| Sentry Crash Report: | |||
| Attachments: | DisplayConfig - Should be Keep / Revert not Revert / Keep | ||
Git commit f1da923305693423ffac87402f45ece0d076d8d1 by Nate Graham. Committed on 17/02/2023 at 20:05. Pushed by ngraham into branch 'master'. kcm: Use correct role for revert button ResetRole is to reset the *dialog* (not the UI it controls) to its default values, which is not what we're using it for here. The correct role is RejectRole. FIXED-IN: 5.27.1 M +1 -1 kcm/package/contents/ui/main.qml https://invent.kde.org/plasma/kscreen/commit/f1da923305693423ffac87402f45ece0d076d8d1 Git commit 06f0671a8337a1c51cc6d6b29c3b1d258c311119 by Nate Graham. Committed on 17/02/2023 at 20:09. Pushed by ngraham into branch 'Plasma/5.27'. kcm: Use correct role for revert button ResetRole is to reset the *dialog* (not the UI it controls) to its default values, which is not what we're using it for here. The correct role is RejectRole. FIXED-IN: 5.27.1 (cherry picked from commit f1da923305693423ffac87402f45ece0d076d8d1) M +1 -1 kcm/package/contents/ui/main.qml https://invent.kde.org/plasma/kscreen/commit/06f0671a8337a1c51cc6d6b29c3b1d258c311119 |
Created attachment 156281 [details] DisplayConfig - Should be Keep / Revert not Revert / Keep SUMMARY *** When changing settings the default in KDE is to have the OK on the left and Cancel on the right. The latest build of KDE 5.27 with KScreen swaps these around. This affects muscle memory and makes it inconsistent with KDE's overall operation. Keep is the same as Ok Revert is the same as Cancel Therefore it should be Ok / Cancel and not Cancel / Ok to be consistent with KDE overall. *** STEPS TO REPRODUCE 1. Right click wallpaper 2. Configure Display Settings 3. Change anything eg scale and click apply. OBSERVED RESULT Windows pops up saying "Revert / Keep" EXPECTED RESULT This should be "Keep / Revert" SOFTWARE/OS VERSIONS Operating System: ArcoLinux KDE Plasma Version: 5.27.0 KDE Frameworks Version: 5.103.0 Qt Version: 5.15.8 Kernel Version: 6.1.12-1-cachyos-bore (64-bit) Graphics Platform: Wayland Processors: 32 × AMD Ryzen 9 5950X 16-Core Processor Memory: 31.3 GiB of RAM Graphics Processor: AMD Radeon RX 5700 XT Manufacturer: Micro-Star International Co., Ltd. Product Name: MS-7C91 System Version: 2.0 Atttached shows to dialogs, one from KDE and the other from Displayconfig.