| Summary: | If a floating tile is split nether splits can be deleted | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Nicholas Omann <alphacluster> |
| Component: | Custom Tiling | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, nate, notmart, postix |
| Priority: | NOR | ||
| Version: | 5.27.0 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/0be551c6bf565a939e179e7b0533dfb165167120 | Version Fixed In: | 5.27.4 |
| Sentry Crash Report: | |||
|
Description
Nicholas Omann
2023-02-15 03:06:50 UTC
Sorry for the quick comment but I have more information from testing. I did confirm same behavior when vertical is done instead and it's not just delete all the buttons for the split tile close the layout editor. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/3606 Git commit 7b46f101e33f870a6116e04bd940b1113278bd44 by David Edmundson. Committed on 15/02/2023 at 23:05. Pushed by davidedmundson into branch 'master'. Simplify tile dismissal We want floating tiles to be activatable, but also dismiss the effect by clicking on the whitespace. The current solution doesn't work as a floating tile that is in turn split will pull focus from the children meaning those tiles can't be deleted. Rather than special casing and z-manipulation we can simplify everything by moving tile dismissal to the root of the effect and appropariately propagating the event. M +3 -3 src/effects/tileseditor/qml/TileDelegate.qml M +5 -0 src/effects/tileseditor/qml/main.qml https://invent.kde.org/plasma/kwin/commit/7b46f101e33f870a6116e04bd940b1113278bd44 Still experience this on Operating System: openSUSE Tumbleweed 20230312 KDE Plasma Version: 5.27.2 KDE Frameworks Version: 5.104.0 Qt Version: 5.15.8 Graphics Platform: Wayland Graphics Processor: AMD Radeon RX 580 Series A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/3836 Seems it was never added to 5.27 (In reply to David Edmundson from comment #6) > Seems it was never added to 5.27 Thanks David! Git commit 0be551c6bf565a939e179e7b0533dfb165167120 by David Edmundson. Committed on 17/03/2023 at 16:18. Pushed by davidedmundson into branch 'Plasma/5.27'. Simplify tile dismissal We want floating tiles to be activatable, but also dismiss the effect by clicking on the whitespace. The current solution doesn't work as a floating tile that is in turn split will pull focus from the children meaning those tiles can't be deleted. Rather than special casing and z-manipulation we can simplify everything by moving tile dismissal to the root of the effect and appropariately propagating the event. (cherry picked from commit 7b46f101e33f870a6116e04bd940b1113278bd44) M +3 -3 src/effects/tileseditor/qml/TileDelegate.qml M +5 -0 src/effects/tileseditor/qml/main.qml https://invent.kde.org/plasma/kwin/commit/0be551c6bf565a939e179e7b0533dfb165167120 |