Bug 464755

Summary:	Keyboard backlight toggle should restore value when toggling off and on again
Product:	[Plasma] Powerdevil	Reporter:	Werner Sembach [TUXEDO] <wse>
Component:	general	Assignee:	Natalie Clarius <natalie_clarius>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	me, natalie_clarius, nate
Priority:	NOR
Version:	5.26.5
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/powerdevil/-/commit/072c4e1d94cf02b19f52def1681a43c0e99b683d	Version Fixed In:	6.0

Description Werner Sembach [TUXEDO] 2023-01-24 17:47:35 UTC

Currently hitting a keyboard backlight toggle key (e.g. a fn key) switches they keyboard backlight to 0% from any % other then 0% and to 100% when it was 0% before. The percentage it was befor being switched of is not saved.

This would be way more usefull if one could for example set keyboard backlight brightness to 50% and then use the toggle key to switch between 0 and 50% instead of 0 and 100%

Comment 1 Bug Janitor Service 2023-08-09 22:42:53 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/powerdevil/-/merge_requests/206

Comment 2 Nate Graham 2023-08-14 15:53:17 UTC

Git commit 072c4e1d94cf02b19f52def1681a43c0e99b683d by Nate Graham, on behalf of Natalie Clarius.
Committed on 14/08/2023 at 17:51.
Pushed by ngraham into branch 'master'.

Restore previous brightness value after toggling keyboard backlight

... provided it was not already zero, instead of always setting to maximum brightness.

FIXED-IN: 6.0

M  +14   -1    daemon/backends/upower/powerdevilupowerbackend.cpp
M  +1    -0    daemon/backends/upower/powerdevilupowerbackend.h
M  +1    -1    daemon/powerdevilbackendinterface.cpp
M  +3    -0    daemon/powerdevilbackendinterface.h
M  +15   -3    daemon/powerdevilbrightnesslogic.cpp
M  +11   -1    daemon/powerdevilbrightnesslogic.h

https://invent.kde.org/plasma/powerdevil/-/commit/072c4e1d94cf02b19f52def1681a43c0e99b683d