Bug 462867

Summary: New Wish - Add holidays for Malaysia
Product: [Frameworks and Libraries] frameworks-kholidays Reporter: ramchyld <ramchyld>
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: winter
Priority: NOR    
Version: 5.100.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://invent.kde.org/frameworks/kholidays/commit/eafaf5541f60fcd2db3dcd45a9707542c796bdc2 Version Fixed In: 5.102.0
Sentry Crash Report:
Attachments: Proposed Plan2 file for holidays in Malaysia

Description ramchyld 2022-12-10 21:08:49 UTC 
Follow up of bug 251318. In the end only holidays for Singapore were implemented. Holidays for Malaysia are still missing.

Google has a publicly viewable calendar for Holidays in Malaysia at this address: https://calendar.google.com/calendar/embed?src=en.malaysia%23holiday%40group.v.calendar.google.com&ctz=Asia%2FKuala_Lumpur

Kindly consider implementing the holidays.
Comment 1 ramchyld 2022-12-11 14:02:46 UTC 
Created attachment 154496 [details]
Proposed Plan2 file for holidays in Malaysia

Attached is the proposed Plan2 file for Malaysia. I can implement most of the holidays as hands-off thanks to the support for indian and islamic calendars and the rest being fixed-date. However I am not able to implement Chinese holidays as hands-off due to the framework apparently not supporting the Chinese calendar yet.
Comment 2 ramchyld 2022-12-11 14:06:56 UTC 
PS: Will also need checking on the islamic and indian national calendars to make sure the month names are correct.
Comment 3 Allen Winter 2022-12-17 12:10:00 UTC 
Thanks for the contribution.
I'll commit your file, but with some fixes to the month names in the indiannationalcalendar:

pausha => paush
vaisakha => vaishakh
kartika => kartik

and rejab => rajab for the hijri calendar
Comment 4 Allen Winter 2022-12-17 12:13:22 UTC 
Git commit eafaf5541f60fcd2db3dcd45a9707542c796bdc2 by Allen Winter.
Committed on 17/12/2022 at 12:11.
Pushed by winterz into branch 'master'.

Add holidays for Malaysia

Contributed by ramchyld@gmail.com
FIXED-IN: 5.102.0

M  +1    -0    holidays/holidays.qrc
A  +86   -0    holidays/plan2/holiday_my_en-gb

https://invent.kde.org/frameworks/kholidays/commit/eafaf5541f60fcd2db3dcd45a9707542c796bdc2