| Summary: | Task Manager icons are too small with a 38px panel, but only when using the Small or Normal spacing settings | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | subhuman2222 <subhuman2222> |
| Component: | Task Manager and Icons-Only Task Manager widgets | Assignee: | veggero <niccolo.venerandi> |
| Status: | CLOSED FIXED | ||
| Severity: | minor | CC: | kainz.a, m, nate, niccolo.venerandi, qydwhotmail |
| Priority: | NOR | ||
| Version First Reported In: | 5.26.3 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/2b03cd33ea7e9149b995985a5e029552ace5a7db | Version Fixed In: | 5.27 |
| Sentry Crash Report: | |||
| Attachments: | self-explanatory | ||
|
Description
subhuman2222
2022-11-21 13:04:02 UTC
Can confirm. Not sure what the true bug is here, though: 1. The fact that the icons *don't* switch to the next largest size with a 38px oanel 2. The fact that the icons *do* switch to the next largest size at 38px panel when you're using the large spacing setting Definitely at least one of those should be fixed. (In reply to Nate Graham from comment #1) > Can confirm. > > Not sure what the true bug is here, though: > 1. The fact that the icons *don't* switch to the next largest size with a > 38px oanel > 2. The fact that the icons *do* switch to the next largest size at 38px > panel when you're using the large spacing setting > > Definitely at least one of those should be fixed. well, the icons did switch to the next largest size before, so (i wish) number 1 should be fixed I'm afraid the bug is 2, not 1. Sorry (In reply to veggero from comment #3) > I'm afraid the bug is 2, not 1. Sorry well i just hope it will look like it looked all these years A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1362 Git commit 0ed0ae8a90e44f34d67495e650d520965352c21c by Nate Graham, on behalf of Niccolò Venerandi. Committed on 01/02/2023 at 15:59. Pushed by ngraham into branch 'master'. applets/taskmanager: Fix icon size when spacing is set to large By applying the 3x margins on "large" spacing to both horizontal and vertical margins, we're also compressing the icon to be too small by triggering a condition in the minimum size check. With this commit, switching to "large" while the panel is at 38px shouldn't change the size of the icon anymore. FIXED-IN: 5.27 M +2 -2 applets/taskmanager/package/contents/ui/code/layout.js https://invent.kde.org/plasma/plasma-desktop/commit/0ed0ae8a90e44f34d67495e650d520965352c21c Git commit 2b03cd33ea7e9149b995985a5e029552ace5a7db by Nate Graham, on behalf of Niccolò Venerandi. Committed on 01/02/2023 at 15:59. Pushed by ngraham into branch 'Plasma/5.27'. applets/taskmanager: Fix icon size when spacing is set to large By applying the 3x margins on "large" spacing to both horizontal and vertical margins, we're also compressing the icon to be too small by triggering a condition in the minimum size check. With this commit, switching to "large" while the panel is at 38px shouldn't change the size of the icon anymore. FIXED-IN: 5.27 (cherry picked from commit 0ed0ae8a90e44f34d67495e650d520965352c21c) M +2 -2 applets/taskmanager/package/contents/ui/code/layout.js https://invent.kde.org/plasma/plasma-desktop/commit/2b03cd33ea7e9149b995985a5e029552ace5a7db Note that the fix here was to make icons smaller when using the "Large" spacing, as the real bug was that they were too big when using "Large" spacing and a 38px panel. If you want icons to be bigger, make the panel 40px. |