| Summary: | Thunderbolt settings side panel has invisible content for large window sizes | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Vorpal <kdebugs> |
| Component: | kcm_thunderbolt | Assignee: | Nate Graham <nate> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | atescomp, nate |
| Priority: | NOR | ||
| Version First Reported In: | 5.26.2 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-thunderbolt/-/commit/d8474c7594093b9cb58ea618a1c029425a3327cb | Version Fixed In: | 5.27.6 |
| Sentry Crash Report: | |||
| Attachments: |
Result on large monitor
Results with small window size (works as expected) |
||
|
Description
Vorpal
2022-10-28 09:21:10 UTC
Created attachment 153256 [details]
Results with small window size (works as expected)
Reviewing this issue, I see the same. Reducing the screen to the smallest size shows the side content for the selected item. As the screen is widened, the side content is pushed into "unseen territory" to the right. Also, the separator bar should be user adjustable / movable. I could probably fix this easily if I had any Thunderbolt hardware with which to test the page, but alas, I don't. Nate, there's a fakeserver in the autotests directory that implements the Bolt daemon DBus interface. You can give it some fake Thunderbird device configuration (there's one in the data subdir) and then run the KCM with `KBOLT_FAKE` env var set. The library will then talk to the fake server instead of the real bolt system daemon. This way you should be able to see something in the KCM and interact with it, even if you don't have physical Thunderbolt on your system. I should say I'd look into it myself, but this is most likely a Kirigami/UI issue which you will be much faster at fixing than myself :) Yay I got it working! Will fix. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-thunderbolt/-/merge_requests/25 Now that I can hack on the KCM, after that MR is merged, I'll submit another one modernizing its UI to bring it up to date with the latest styling for Plasma 6. That one won't be backportable to 5, of course. Thanks a lot for writing that fake server. Really nice touch. Git commit 519c48a78e9e050b8d3c86ea576b3a88a9d3787a by Nate Graham. Committed on 18/06/2023 at 16:22. Pushed by ngraham into branch 'master'. Fix UI with huge window sizes Using a KCM-within-a-KCM paradigm was not ideal and caused weird layout glitches. We can fix them all by changing the device list page to be a plain old Kirigami.ScrollablePage. FIXED-IN: 5.27.6 M +2 -2 src/kcm/ui/DeviceList.qml https://invent.kde.org/plasma/plasma-thunderbolt/-/commit/519c48a78e9e050b8d3c86ea576b3a88a9d3787a Git commit d8474c7594093b9cb58ea618a1c029425a3327cb by Nate Graham. Committed on 18/06/2023 at 16:23. Pushed by ngraham into branch 'Plasma/5.27'. Fix UI with huge window sizes Using a KCM-within-a-KCM paradigm was not ideal and caused weird layout glitches. We can fix them all by changing the device list page to be a plain old Kirigami.ScrollablePage. FIXED-IN: 5.27.6 (cherry picked from commit 519c48a78e9e050b8d3c86ea576b3a88a9d3787a) M +2 -2 src/kcm/package/contents/ui/DeviceList.qml https://invent.kde.org/plasma/plasma-thunderbolt/-/commit/d8474c7594093b9cb58ea618a1c029425a3327cb |