| Summary: | Ctrl+PageUp/PageDown shortcuts navigate up or down twice | ||
|---|---|---|---|
| Product: | [Applications] NeoChat | Reporter: | Nate Graham <nate> |
| Component: | General | Assignee: | Tobias Fella <fella> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | carl |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/network/neochat/commit/e0f16054fca51590f05c250cec60a234dad3ac9e | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2022-10-05 08:39:25 UTC
This looks like a Qt bug; the signal we connect to is emitted twice A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/676 A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/807 Git commit e0f16054fca51590f05c250cec60a234dad3ac9e by Tobias Fella, on behalf of Kevin Wolf. Committed on 20/02/2023 at 17:07. Pushed by tfella into branch 'master'. Fix Ctrl+PgUp/PgDn shortcut for room switching Before this change, Ctrl+PgUp/PgDown didn't select the next room, but actually moved two rooms at once because the signal handler was called twice. I'm not entirely sure why this happens (it might be a bug in a lower layer?), but as we don't want to handle the same event elsewhere, accepting the event doesn't feel wrong and it appears to fix the issue. So let's just do that. M +2 -0 src/qml/Page/RoomPage.qml https://invent.kde.org/network/neochat/commit/e0f16054fca51590f05c250cec60a234dad3ac9e |