Bug 459418

Summary:	Ark should check if there is sufficient free space available in destination before start extraction
Product:	[Applications] ark	Reporter:	Patrick Silva <bugseforuns>
Component:	general	Assignee:	Elvis Angelaccio <elvis.angelaccio>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	aacid, nate, rthomsen6
Priority:	NOR	Keywords:	usability
Version First Reported In:	22.08.1
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/utilities/ark/commit/6cbcbb4a7972c0887ab8e8be4c7ebd7ff5f27e00	Version Fixed/Implemented In:	22.12.3
Sentry Crash Report:

Description Patrick Silva 2022-09-20 01:01:51 UTC

SUMMARY
Similar to bug 393959. Currently Ark checks if there is sufficient free space in the destination when I try to extract archives via context menu of Dolphin, but the same does not occur when I open an archive with Ark and then try to extract it by clicking on 'Extract' button.


STEPS TO REPRODUCE
1. open an archive with Ark
2. click on 'Extract' button
3. choose a file system with insufficient free space as destination and click on 'Extract' button

OBSERVED RESULT
extraction starts and then fails with different results depending on the type of the archive used.
If a 7zip archive is used, I get the error 'Extraction failed due to unknown reason', if any variant of tar archive is used a notification falsely says 'Extracting all files (Finished)', if zip or jar archive is used the error 'Failed to write data for entry: <filename>' appears.

EXPECTED RESULT
extraction should start only if there is sufficient free space in the destination

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.25.90
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.6
Graphics Platform: Wayland

Comment 1 Elvis Angelaccio 2023-02-27 19:00:06 UTC

Git commit fcd9a966a5f6a2180431fddf331447bef2434fc3 by Elvis Angelaccio, on behalf of Nikita Karpei.
Committed on 27/02/2023 at 18:59.
Pushed by elvisangelaccio into branch 'master'.

Fix free space check
FIXED-IN: 22.12.3

M  +6    -0    kerfuffle/archiveentry.cpp
M  +3    -0    kerfuffle/archiveentry.h
M  +1    -1    kerfuffle/archiveinterface.cpp
M  +11   -5    kerfuffle/jobs.cpp
M  +1    -0    plugins/libarchive/libarchiveplugin.cpp

https://invent.kde.org/utilities/ark/commit/fcd9a966a5f6a2180431fddf331447bef2434fc3

Comment 2 Elvis Angelaccio 2023-02-27 22:52:44 UTC

Git commit 6cbcbb4a7972c0887ab8e8be4c7ebd7ff5f27e00 by Elvis Angelaccio, on behalf of Nikita Karpei.
Committed on 27/02/2023 at 22:19.
Pushed by elvisangelaccio into branch 'release/22.12'.

Fix free space check
FIXED-IN: 22.12.3


(cherry picked from commit fcd9a966a5f6a2180431fddf331447bef2434fc3)

M  +6    -0    kerfuffle/archiveentry.cpp
M  +3    -0    kerfuffle/archiveentry.h
M  +1    -1    kerfuffle/archiveinterface.cpp
M  +11   -5    kerfuffle/jobs.cpp
M  +1    -0    plugins/libarchive/libarchiveplugin.cpp

https://invent.kde.org/utilities/ark/commit/6cbcbb4a7972c0887ab8e8be4c7ebd7ff5f27e00