Bug 458941

Summary:	Copy merged crashes the application
Product:	[Applications] krita	Reporter:	Pablo <netinfo2k>
Component:	Usability	Assignee:	Dmitry Kazakov <dimula73>
Status:	RESOLVED FIXED
Severity:	crash	CC:	halla, starwarfan14
Priority:	NOR
Version:	5.1.0
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/commit/1d9698635a0f8289263bcb057727bf69cb48e8fa	Version Fixed In:

Description Pablo 2022-09-10 01:23:22 UTC

Selecting all the image that is being edited (ctrl+A) and doing "copy merged" crashes the application.



STEPS TO REPRODUCE
1. Create a new document
2. Select all with ctrl+A
3. Select Copy merged from the Edit menu

OBSERVED RESULT
The following messages is repeated indefinitely in the console (since I start the app from the command line) until application crashes.
SAFE ASSERT (krita): "qAbs(row) < 0x7FFF && qAbs(col) < 0x7FFF" in file /home/appimage/workspace/Krita_Release_Appimage_Build/krita/libs/image/tiles3/kis_tile_hash_table2.h, line 151

The crash doesn't occur if part of the image is selected, like using any of the selection tools.


EXPECTED RESULT
The application should be copied with all the layers merged.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Dmitry Kazakov 2022-09-16 11:08:33 UTC

Git commit aac9375843b3018564cea285b91f82c7f3b9fda2 by Dmitry Kazakov.
Committed on 16/09/2022 at 11:07.
Pushed by dkazakov into branch 'master'.

Fix a crash when trying to copy-paste the background layer

Such layers usually have non-transparent default pixel, which
automatically needs an image for exact bounds calculation, which
doesn't exist for the detached layers.

The patch saves the copied area bounds on the construction
of mime data, much before the layers become detached.
Related: bug 458890, bug 458857, bug 458248

M  +12   -11   libs/ui/kis_mimedata.cpp
M  +2    -0    libs/ui/kis_mimedata.h

https://invent.kde.org/graphics/krita/commit/aac9375843b3018564cea285b91f82c7f3b9fda2

Comment 2 Dmitry Kazakov 2022-09-16 11:09:08 UTC

Git commit 1d9698635a0f8289263bcb057727bf69cb48e8fa by Dmitry Kazakov.
Committed on 16/09/2022 at 11:09.
Pushed by dkazakov into branch 'krita/5.1'.

Fix a crash when trying to copy-paste the background layer

Such layers usually have non-transparent default pixel, which
automatically needs an image for exact bounds calculation, which
doesn't exist for the detached layers.

The patch saves the copied area bounds on the construction
of mime data, much before the layers become detached.
Related: bug 458890, bug 458857, bug 458248


(cherry picked from commit aac9375843b3018564cea285b91f82c7f3b9fda2)

M  +12   -11   libs/ui/kis_mimedata.cpp
M  +2    -0    libs/ui/kis_mimedata.h

https://invent.kde.org/graphics/krita/commit/1d9698635a0f8289263bcb057727bf69cb48e8fa

Comment 3 amyspark 2022-09-26 16:47:06 UTC

*** Bug 459703 has been marked as a duplicate of this bug. ***