| Summary: | dialog-information icon is not displayed in notifications | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Sadi <sadiyumusak> |
| Component: | Notifications | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | kainz.a, kde, m, nate, nicolas.fella |
| Priority: | NOR | ||
| Version First Reported In: | 5.25.5 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/f9a1b9566ecef1998bee73a08a740bb90c0bf4a3 | Version Fixed/Implemented In: | 5.26 |
| Sentry Crash Report: | |||
| Attachments: | Screenshot of "dialog-*" icons in KDialogs | ||
This isn't caused by the icon theme. The reason this particular icon is not displayed is that Plasma explicitly does not show this icon in notifications: https://invent.kde.org/plasma/plasma-workspace/-/blob/master/applets/notifications/package/contents/ui/NotificationItem.qml#L291 Seems like we're outsmarting ourselves here lol A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2097 Git commit f9a1b9566ecef1998bee73a08a740bb90c0bf4a3 by Nate Graham. Committed on 10/09/2022 at 21:27. Pushed by ngraham into branch 'master'. applets/notifications: stop suppressing dialog-information icon This will feel weird and random to the user, especially if they or one of their apps deliberately uses that icon and then it unexpectedly isn't displayed. This check feels too magical and unpredictable; let's remove it to simplify things. FIXED-IN: 5.26 M +1 -2 applets/notifications/package/contents/ui/NotificationItem.qml https://invent.kde.org/plasma/plasma-workspace/commit/f9a1b9566ecef1998bee73a08a740bb90c0bf4a3 |
Created attachment 151892 [details] Screenshot of "dialog-*" icons in KDialogs SUMMARY *** I've just noticed that dialog-information icon is not displayed in kdialog passivepopups while all the others in that icon set "dialog-*.svg" are displayed as expected. *** STEPS TO REPRODUCE Enter these commands in a terminal window: kdialog --icon "dialog-error" --title "dialog-error icon" --passivepopup "Displayed" & kdialog --icon "dialog-information" --title "dialog-information icon" --passivepopup "<b>NOT Displayed</b>" & kdialog --icon "dialog-positive" --title "dialog-positive icon" --passivepopup "Displayed" & kdialog --icon "dialog-question" --title "dialog-question icon" --passivepopup "Displayed" & kdialog --icon "dialog-warning" --title "dialog-warning icon" --passivepopup "Displayed" & kdialog --title "Test" --msgbox "dialog-information icon is displayed" OBSERVED RESULT All those icons are displayed in kdialog passivepopups with only one exception: dialog-information. However, it is displayed in kdialog msgbox irrespective of icon option there. EXPECTED RESULT The icon "dialog-information" should be displayed in kdialog passivepopups as well. SOFTWARE/OS VERSIONS Operating System: KDE neon 5.25 KDE Plasma Version: 5.25.5 KDE Frameworks Version: 5.97.0 Qt Version: 5.15.5