Bug 458222

Summary:	Network QR codes have insufficient quiet zone
Product:	[Frameworks and Libraries] frameworks-prison	Reporter:	Nagy Tibor <xnagytibor>
Component:	general	Assignee:	Sune Vuorela <sune>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jgrulich, nate
Priority:	NOR
Version First Reported In:	5.97.0
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/prison/commit/b17216263ba1ae1c2896b5ead715cb52622e268f	Version Fixed/Implemented In:	5.99
Sentry Crash Report:

Description Nagy Tibor 2022-08-23 19:54:41 UTC

SUMMARY
The QR codes that the network applet shows on "Show network's QR code" are not spec compliant, they have insufficient quiet zone around the symbol. Spec says the quiet zone around normal-sized QR codes should be at least 4 modules instead of the current 2 modules.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.25
KDE Plasma Version: 5.25.3
KDE Frameworks Version: 5.96.0
Qt Version: 5.15.5
Graphics Platform: X11

Comment 1 Nate Graham 2022-08-30 21:50:59 UTC

This barcode image comes from Prison; moving the bug report there.

Comment 2 Sune Vuorela 2022-10-01 10:26:29 UTC

Git commit c3133beb21decdbf44c74eb89ffe2471af04f897 by Sune Vuorela.
Committed on 01/10/2022 at 10:25.
Pushed by sune into branch '458222-increase-qrcode-quiet-zone'.

Increase quiet zone for qrcode

M  +1    -1    src/lib/qrcodebarcode.cpp

https://invent.kde.org/frameworks/prison/commit/c3133beb21decdbf44c74eb89ffe2471af04f897

Comment 3 Sune Vuorela 2022-10-01 12:31:51 UTC

Git commit b17216263ba1ae1c2896b5ead715cb52622e268f by Sune Stolborg Vuorela.
Committed on 01/10/2022 at 12:31.
Pushed by sune into branch 'master'.

Increase quiet zone for qrcode

Closes #458222

M  +-    --    autotests/qr/qr-binary.png
M  +-    --    autotests/qr/qr-text.png
M  +1    -1    src/lib/qrcodebarcode.cpp

https://invent.kde.org/frameworks/prison/commit/b17216263ba1ae1c2896b5ead715cb52622e268f