| Summary: | Click-and-hold enters Selection Mode, but tap-and-hold does not | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Nate Graham <nate> |
| Component: | Selection Mode | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | felixernst, kfm-devel, meven29 |
| Priority: | NOR | Keywords: | usability |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=458129 | ||
| Latest Commit: | https://invent.kde.org/system/dolphin/-/commit/71ea4a88d890949500d05aa21839ad93ec6bdb1d#note_540150 | Version Fixed In: | 22.12 |
|
Description
Nate Graham
2022-08-16 21:27:23 UTC
>press-and-hold using a touch device should enter Selection Mode rather >than showing the context menu I agree, that is not implemented yet. >Click-and-hold should generally do nothing when using a pointing device I implemented that one based on Andy's feedback here: https://invent.kde.org/system/dolphin/-/merge_requests/273#note_305006 Andy mentioned the advantage of this. Not sure how bad the downsides of this are. One potential issue I see is that users might be click-and-holding to begin a drag and drop operation and then be surprised by selection mode triggering because they didn't move their mouse fast enough. I had this tested and working originally. I just tested again if this could be a problem and it currently is because of Bug 457973. But if that bug was already fixed it probably wouldn't be. I want to mention that removing the behaviour of entering selection mode when click-and-holding is as easy as removing the line " Q_EMIT selectionModeChangeRequested(true);" here: https://invent.kde.org/system/dolphin/-/blob/master/src/kitemviews/kitemlistcontroller.cpp#L1063 This would also fix Bug 457973. Easy profits! For now we should probably figure out if we want click-and-hold with a pointing device to enter selection mode or not because this might affect the necessary implementation to fix the other touch device behaviour change that is being requested here. I think we should probably never enter Selection Mode with click-and-hold using a pointing device. In general users find this surprising and don't like it. For reference, we just removed this from Plasma in https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2031. A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/439 Git commit 4ddc4159ed5d9fb6e7b7c6edc1b04460f87c984b by Felix Ernst. Committed on 27/08/2022 at 09:40. Pushed by felixernst into branch 'master'. This commit removes the ability to enter selection mode by click-and-holding with a pointing device like a mouse. This functionality was originally implemented because it seemed useful to save users the effort of entering selection mode explicitly by using its corresponding action. However, click-and-holding to trigger anything is not really an expected behaviour. (This contrasts with touch devices where press-and-holding is common to trigger something.) Aside from the above reasoning, the click-and-hold behaviour was also buggy so that selection mode was entered in a couple of situations that weren't strictly about click-and-holding. So this commit removes the functionality and the bugs. Related: bug 457973, bug 458129 M +0 -1 src/kitemviews/kitemlistcontroller.cpp https://invent.kde.org/system/dolphin/commit/4ddc4159ed5d9fb6e7b7c6edc1b04460f87c984b |