| Summary: | Favorites category uses a monochrome icon, whereas everything else uses a colorful icon | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | D3XT3R <tresdexter> |
| Component: | Application Launcher (Kickoff) widget | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | akontsevich, alanas.00, m, mikel5764, nate, noahadvs |
| Priority: | NOR | ||
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=474275 https://bugs.kde.org/show_bug.cgi?id=499825 |
||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/3c57be395b0eadc6973971cb5b36d8810e99c39f | Version Fixed In: | 6.2.0 |
| Sentry Crash Report: | |||
| Attachments: |
Monochrome icons.
Kickoff and KMenuEdit show different menu icon Still symbolic icon in the Kickoff (Places) |
||
The help icon has already been fixed in https://invent.kde.org/frameworks/breeze-icons/-/commit/acc75ff7762d7de0bd6489abc821dba506c2a43b. Let's use this bug report to track fixing the Favorites icon. So there are a few problems here: * in plasma-workspace/applets/kicker/plugin/rootmodel.cpp, we use the `bookmarks` icon which is not semantically correct, as a bookmark is something different from a favorited item. * If we switched to using either of the more semantically correct `favorite` or `favorites` icon, those icons in the Breeze icon theme are also monochrome at their small sizes I see two ways we could proceed here: 1. Change the `bookmarks` icon in the Plasma theme to look like a colorful star 2. Change the icon used to `applications-favorites` and create that icon in the Breeze icon theme, ensuring there's a colorful version for both the 22px and 32px sizes. Noah and Manuel, what do you think? We'd need a colorful version of this icon. There is `folder-favorites` but that looks like a folder and doesn't quite seem appropriate. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2415 Git commit 702841df746e7a4b13e9fa76ca4a53f5de10347d by Nate Graham. Committed on 23/09/2024 at 20:36. Pushed by ngraham into branch 'master'. applets/kickoff: use symbolic icons for categories This follows the HIG guidance that list items with 22px icons should generally prefer the symbolic style. It makes Kickoff consistent with all the other list items that use the symbolic style at this size. FIXED-IN: 6.2.0 Co-authored-by: Noah Davis <noahadvs@gmail.com> M +12 -1 applets/kickoff/package/contents/ui/KickoffListDelegate.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/702841df746e7a4b13e9fa76ca4a53f5de10347d Git commit 3c57be395b0eadc6973971cb5b36d8810e99c39f by Nate Graham. Committed on 23/09/2024 at 20:39. Pushed by ngraham into branch 'Plasma/6.2'. applets/kickoff: use symbolic icons for categories This follows the HIG guidance that list items with 22px icons should generally prefer the symbolic style. It makes Kickoff consistent with all the other list items that use the symbolic style at this size. FIXED-IN: 6.2.0 Co-authored-by: Noah Davis <noahadvs@gmail.com> (cherry picked from commit 702841df746e7a4b13e9fa76ca4a53f5de10347d) 4fcfc56c applets/kickoff: use symbolic icons for categories 0e385a22 Apply 1 suggestion(s) to 1 file(s) Co-authored-by: Nate Graham <nate@kde.org> M +12 -1 applets/kickoff/package/contents/ui/KickoffListDelegate.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/3c57be395b0eadc6973971cb5b36d8810e99c39f Created attachment 174133 [details] Kickoff and KMenuEdit show different menu icon (In reply to Nate Graham from comment #6) > It makes Kickoff consistent with > all the other list items that use the symbolic style at this size. But it also makes Kickoff inconsistent with KMenuEdit. It does. I looked into an alternative method that wouldn't suffer from that issue, but it introduces different issues. See https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2561#note_1045513 Created attachment 178239 [details]
Still symbolic icon in the Kickoff (Places)
There is still a symbolic icon in th Kickoff (Places icon) and I have not found a way to change it to colorful one. It does not justify at all with the overall icons' and kickoff's style. Should we reopen this ticket as non complete?
In that specific case, it's because the icon theme you're using is missing a colorful icon for `compass`. Icons are still symbolic for me in the menu: how to change them?! This bug report is about the Favorites icon being the only symbolic icon in the sidebar. That issue was fixed by making everything else symbolic by default as well, so they all match The category icons can be changed using KMenuEdit. The icon names for Favorites and All Applications are currently hardcoded, and therefore their appearance cannot be changed without changing icon themes or patching the code to use a different icon name. Stupid logic, for now solved by manually removing symbolic icons completely. |
Created attachment 150871 [details] Monochrome icons. In order to maintain consistency, the monochrome icons of the Favorites and Help items should be replaced by colored icons.