| Summary: | Duplicate shortcut keys in tooltips | ||
|---|---|---|---|
| Product: | [Applications] kolourpaint | Reporter: | D3XT3R <tresdexter> |
| Component: | general | Assignee: | kolourpaint-support |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | felixernst, nate |
| Priority: | NOR | ||
| Version First Reported In: | 22.04.3 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/kolourpaint/commit/906b97b482c0ab45526c1deea684d3d37f4c3a45 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Duplicate shortcut keys in tooltips | ||
Can reproduce. Might be an issue in the common tooltip code, or might be an issue in how Kolourpaint assigns shortcuts. CCing Felix Ernst, who is much more knowledgeable about this than I am. A possibly relevant merge request was started @ https://invent.kde.org/graphics/kolourpaint/-/merge_requests/22 I am knowledgeable about this bug because I caused it. ^^' Git commit 906b97b482c0ab45526c1deea684d3d37f4c3a45 by Felix Ernst. Committed on 19/07/2022 at 20:24. Pushed by felixernst into branch 'master'. Show keyboard shortcuts in tooltips only once not twice The tools on the left bar of Kolourpaint show their respective keyboard shortcuts in their tooltips. There was a change in KDE frameworks (https://commits.kde.org/kxmlgui/ecd7cefd8d4b8ddb15b8e3a3e6e9bd5c55a9c12c) that made it so all tooltips of actions show their keyboard shortcuts in their tooltips by default. Together this meant that the keyboard shortcut is shown twice. This commit fixes this by removing the Kolourpaint-specific code to show the keyboard shortcut in the tooltip. M +0 -33 tools/kpTool.cpp M +0 -6 tools/kpTool.h M +0 -18 tools/kpToolAction.cpp M +0 -3 tools/kpToolAction.h https://invent.kde.org/graphics/kolourpaint/commit/906b97b482c0ab45526c1deea684d3d37f4c3a45 |
Created attachment 150720 [details] Duplicate shortcut keys in tooltips All shortcut keys are duplicated in Kolorpaint tooltips.