Summary: | SystemTray App Strawberry Middle Click To PlayPause Is Ignored After Plasma 5.25 Update | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Chris Holland <zrenfire> |
Component: | System Tray | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugseforuns, materka, nate, qydwhotmail |
Priority: | NOR | ||
Version: | 5.25.0 | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/627d6ab6772bd4088107dbb642871996221a7e92 | Version Fixed In: | 5.25.3 |
Description
Chris Holland
2022-07-08 00:46:07 UTC
Well the "StatusNotifierItem.qml:74: TypeError: Property 'operationDescription' of object NaN is not a function" warning made it obvious that I was blind when skimming the code. https://invent.kde.org/plasma/plasma-workspace/-/blame/master/applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml#L69-70 Looks like this commit defined the service variable after the operation call accidentally when moving stuff around. var operation = service.operationDescription("SecondaryActivate"); let service = model.Service; https://invent.kde.org/plasma/plasma-workspace/-/commit/8031139aeb7f412ff3f8b9d7b1bd1d2fa16e7a2b#a3d37774fcfbf0224e15156bfd485eb9438664c1_71_70 Can confirm on Arch Linux (Plasma 5.25.2) and neon unstable. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1904 Git commit b3943ee1a63c96e48f7a0706d8296b67aaf5ba1e by Chris Holland. Committed on 08/07/2022 at 15:35. Pushed by cholland into branch 'master'. Fix StatusNotifierItem MidClick Bug was introduced in !1798's 8031139a commit. M +1 -1 applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml https://invent.kde.org/plasma/plasma-workspace/commit/b3943ee1a63c96e48f7a0706d8296b67aaf5ba1e Git commit 627d6ab6772bd4088107dbb642871996221a7e92 by Fushan Wen, on behalf of Chris Holland. Committed on 09/07/2022 at 04:23. Pushed by fusionfuture into branch 'Plasma/5.25'. Fix StatusNotifierItem MidClick Bug was introduced in !1798's 8031139a commit. FIXED=IN: 5.25.3 (cherry picked from commit b3943ee1a63c96e48f7a0706d8296b67aaf5ba1e) M +2 -2 applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml https://invent.kde.org/plasma/plasma-workspace/commit/627d6ab6772bd4088107dbb642871996221a7e92 |