Bug 455920

Summary:	Replace InstallTrigger Firefox check
Product:	[Plasma] plasma-browser-integration	Reporter:	Nico <nico>
Component:	Firefox	Assignee:	Kai Uwe Broulik <kde>
Status:	CONFIRMED ---
Severity:	normal	CC:	kt47uo5uvzw, mario
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:

Description Nico 2022-06-25 14:25:53 UTC

SUMMARY
InstallTrigger check to detect Firefox should be replaced

STEPS TO REPRODUCE
1. Have the addon installed and load a page

OBSERVED RESULT
See console warning:
```
InstallTrigger is deprecated and will be removed in the future. constants.js:50:14
```

EXPECTED RESULT
Should no longer use InstallTrigger to detect Firefox

SOFTWARE/OS VERSIONS
Firefox: 101.0.1 (64-bit)
Plasma Integration: 1.8.1

ADDITIONAL INFORMATION

Comment 1 kt47uo5uvzw 2022-11-03 23:48:46 UTC

The following line needs to be updated:
https://invent.kde.org/plasma/plasma-browser-integration/-/blob/master/extension/constants.js#L50

Comment 2 kt47uo5uvzw 2022-11-03 23:49:19 UTC

The following line needs to be updated:
https://invent.kde.org/plasma/plasma-browser-integration/-/blob/master/extension/constants.js#L50

Comment 3 Mario Bašić 2023-02-06 12:09:30 UTC

I see here https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/75/diffs that there is a fix for this issue, but it seems like the new version of the extension which includes this fix has not been published. 

When will it be published it has been 4 months since this was fixed?

On the same topic, why not implement it like this https://github.com/philc/vimium/commit/c5f232c75ee5fafd95eda456c1db88363902814a ?