Bug 455764

Summary: Plasma 5.25: Present Windows doesn’t allow window selection with arrow keys anymore (X.org)
Product: [Plasma] kwin Reporter: Maximilian Böhm <mabo>
Component: effects-present-windowsAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: mabo, nate, notify
Priority: NOR Keywords: regression
Version: 5.25.1   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 5.25.2

Description Maximilian Böhm 2022-06-21 23:29:12 UTC
In the old implementation, you could chose your window with the arrow keys. Now, they aren’t doing anything. X.org session.

KDE Plasma Version: 5.25.1
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.5
Comment 1 Niklas Stephanblome 2022-06-22 11:44:09 UTC
I made a fix for this so the keyboard navigation matches the old presentwindows one (one window is always selected and you can select another window anytime with the arrow keys without unfocusing the searchbox). Here is is: https://invent.kde.org/plasma/kwin/-/merge_requests/2562 (waiting to be merged at the moment).
Comment 2 Maximilian Böhm 2022-06-22 12:52:44 UTC
Thx.
Comment 3 Nate Graham 2022-06-23 17:14:35 UTC
Git commit 6838b1132fad8b32c26409fd46b2e49803684dd6 by Nate Graham, on behalf of Niklas Stephanblom.
Committed on 23/06/2022 at 17:13.
Pushed by ngraham into branch 'master'.

Windowview: Fix broken keyboard navigation while filtering

After the 5.25 update, one could not see which window was highlighted until one
manually unfocused the SearchField and then pressed any key to refresh the WindowHeap.
Also, the searchbar would (most of the time) "absorb" the arrow keys so one had to
also unfocus it to really be able to select windows with they keyboard. 

With this change, there is always one window highlighted while filtering using the
search box. Also, one can select another window with the arrow keys without manually
unfocusing the searchbox. This heavily improves the keyboard functionality in this
effect that got lost with the 5.25 update of presentwindows to windowview and
resolves complaints about the keyboard navigation being buggy. 
Related: bug 455633, bug 455099, bug 455586, bug 455753
FIXED-IN: 5.25.2

M  +6    -2    src/effects/windowview/qml/main.qml
M  +3    -0    src/effects/windowview/windowvieweffect.cpp

https://invent.kde.org/plasma/kwin/commit/6838b1132fad8b32c26409fd46b2e49803684dd6
Comment 4 Nate Graham 2022-06-23 17:16:49 UTC
Git commit dcc77bfa8fbca8032047fbbb5ab65382293488ac by Nate Graham, on behalf of Niklas Stephanblom.
Committed on 23/06/2022 at 17:16.
Pushed by ngraham into branch 'Plasma/5.25'.

Windowview: Fix broken keyboard navigation while filtering

After the 5.25 update, one could not see which window was highlighted until one
manually unfocused the SearchField and then pressed any key to refresh the WindowHeap.
Also, the searchbar would (most of the time) "absorb" the arrow keys so one had to
also unfocus it to really be able to select windows with they keyboard. 

With this change, there is always one window highlighted while filtering using the
search box. Also, one can select another window with the arrow keys without manually
unfocusing the searchbox. This heavily improves the keyboard functionality in this
effect that got lost with the 5.25 update of presentwindows to windowview and
resolves complaints about the keyboard navigation being buggy. 
Related: bug 455633, bug 455099, bug 455586, bug 455753
FIXED-IN: 5.25.2


(cherry picked from commit 6838b1132fad8b32c26409fd46b2e49803684dd6)

M  +6    -2    src/effects/windowview/qml/main.qml
M  +3    -0    src/effects/windowview/windowvieweffect.cpp

https://invent.kde.org/plasma/kwin/commit/dcc77bfa8fbca8032047fbbb5ab65382293488ac