| Summary: | Unable to continue conversation. After first message sent, "Send Arrow" remains inactive. | ||
|---|---|---|---|
| Product: | [Applications] kdeconnect | Reporter: | alumpezdek |
| Component: | messaging-application | Assignee: | Dmytrii <dzavalny> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dzavalny, rleyvasal |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Slackware | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/network/kdeconnect-kde/commit/0d02a6f99e46e002a89c259ae30b02f23661e06c | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
alumpezdek
2022-06-11 02:59:17 UTC
*** Bug 463248 has been marked as a duplicate of this bug. *** Marking as confirmed since another user reported a duplicate bug and I can reproduce the same behavior. Note that pressing the enter button to send causes the button to be disabled, but you can send multiple messages in the same conversation by using enter to send. If I were guessing, something is wrong with the `disabled` state of the send button, probably in the part of the code where it tries to prevent sending duplicate messages by briefly disabling the button. Marking this as a junior job. It's probably a simple fix, someone just needs to poke into the QML and find where the disabled state of the button is set, and find where it should be re-enabled. (In reply to Simon Redman from comment #2) > Marking as confirmed since another user reported a duplicate bug and I can > reproduce the same behavior. > > Note that pressing the enter button to send causes the button to be > disabled, but you can send multiple messages in the same conversation by > using enter to send. If I were guessing, something is wrong with the > `disabled` state of the send button, probably in the part of the code where > it tries to prevent sending duplicate messages by briefly disabling the > button. > > Marking this as a junior job. It's probably a simple fix, someone just needs > to poke into the QML and find where the disabled state of the button is set, > and find where it should be re-enabled. Hello, I found some QML positioning errors. It is not just enabled/disabled issue. This property depends on messageField textarea which became undefined. I can fix it. Could you assign this bug to me, or should I do it on my own? (In reply to Dmytrii from comment #3) > > Hello, I found some QML positioning errors. It is not just enabled/disabled > issue. This property depends on messageField textarea which became > undefined. I can fix it. Could you assign this bug to me, or should I do it > on my own? Feel free to take ownership yourself. Thanks for stepping up! Please reach out to the team if you get stuck or want to ask questions: https://community.kde.org/KDEConnect#Development Created merge request for this https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/518 Git commit 0d02a6f99e46e002a89c259ae30b02f23661e06c by Simon Redman, on behalf of Dmytrii Zavalnyi. Committed on 21/04/2023 at 16:28. Pushed by sredman into branch 'master'. Fix inactive "Send Arrow" in smsapp after first message sent The "enabled" property of the button was set to false and has overwritten the default value based on the message length. The message field had "anchors.fill" positioning and raised "Binding loop detected for property "implicitHeight"" error. attachmentList property of ChatMessage didn't have the default value and was undefined. M +1 -1 smsapp/qml/ChatMessage.qml M +13 -10 smsapp/qml/SendingArea.qml https://invent.kde.org/network/kdeconnect-kde/commit/0d02a6f99e46e002a89c259ae30b02f23661e06c |