| Summary: | Current wallpaper is no longer highlighted after adding an image | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Patrick Silva <bugseforuns> |
| Component: | Image & Slideshow wallpaper plugins | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, notmart, qydwhotmail |
| Priority: | NOR | Keywords: | regression |
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/89dce8a127a65844cd7a0ae71d185aba403fc4f6 | Version Fixed/Implemented In: | 5.26 |
| Sentry Crash Report: | |||
| Attachments: | screen recording | ||
|
Description
Patrick Silva
2022-06-10 13:42:54 UTC
Can't reproduce on X11. Is it only reproducible on Wayland? I was able to reproduce exactly the observed result mentioned in comment 0 once on X11. Now the result is a bit different on both Wayland and X11: the current wallpaper is not hightlighted immediately after opening an image (the next wallpaper in the grid is highlighted instead), but it is when I reopen the desktop settings. Git commit c857d3bad57b9e8a1606fe9035a01afb91a9033c by Fushan Wen. Committed on 10/06/2022 at 14:53. Pushed by fusionfuture into branch 'master'. wallpapers/image: set position in `resetCurrentIndex` Move the position of the image list view to the currently selected item's index. M +1 -0 wallpapers/image/imagepackage/contents/ui/ThumbnailsComponent.qml https://invent.kde.org/plasma/plasma-workspace/commit/c857d3bad57b9e8a1606fe9035a01afb91a9033c Git commit 1ae570e4b3c6dd6a5e775d24d7ebaed9d31c46a3 by Fushan Wen. Committed on 10/06/2022 at 14:53. Pushed by fusionfuture into branch 'master'. wallpapers/image: scroll to top after finishing adding images using file dialog M +5 -0 wallpapers/image/imagepackage/contents/ui/ThumbnailsComponent.qml M +1 -0 wallpapers/image/plugin/imagebackend.cpp M +5 -0 wallpapers/image/plugin/imagebackend.h https://invent.kde.org/plasma/plasma-workspace/commit/1ae570e4b3c6dd6a5e775d24d7ebaed9d31c46a3 Git commit bf97a204b8e61ac0770551b5194c044e63bcf8f8 by Fushan Wen. Committed on 10/06/2022 at 14:53. Pushed by fusionfuture into branch 'master'. wallpapers/image: scroll to top to view added images after DnD operations M +2 -0 wallpapers/image/imagepackage/contents/ui/ThumbnailsComponent.qml M +5 -0 wallpapers/image/imagepackage/contents/ui/config.qml https://invent.kde.org/plasma/plasma-workspace/commit/bf97a204b8e61ac0770551b5194c044e63bcf8f8 Can't reproduce on Wayland either even before those commits. Need more people to confirm the bug. Also can't confirm the issue. Please reopen this bug if you still see the same phenomenon after updating the system to the latest version. Can reproduce on neon unstable and Arch Linux. Operating System: Arch Linux KDE Plasma Version: 5.25.90 KDE Frameworks Version: 5.98.0 Qt Version: 5.15.6 Graphics Platform: Wayland Still can't reproduce. Do you have a screen record? Created attachment 152410 [details]
screen recording
Here is a video recorded on neon unstable.
Git commit fe9604caa955d4417801f8b2b4dabf1ad4350397 by Fushan Wen. Committed on 25/09/2022 at 10:59. Pushed by fusionfuture into branch 'master'. wallpapers/image: reset grid index after new images are added Otherwise the index will still be the old index. FIXED-IN: 5.26 M +1 -0 wallpapers/image/imagepackage/contents/ui/ThumbnailsComponent.qml https://invent.kde.org/plasma/plasma-workspace/commit/fe9604caa955d4417801f8b2b4dabf1ad4350397 Git commit 89dce8a127a65844cd7a0ae71d185aba403fc4f6 by Fushan Wen. Committed on 25/09/2022 at 11:00. Pushed by fusionfuture into branch 'Plasma/5.26'. wallpapers/image: reset grid index after new images are added Otherwise the index will still be the old index. FIXED-IN: 5.26 (cherry picked from commit fe9604caa955d4417801f8b2b4dabf1ad4350397) M +1 -0 wallpapers/image/imagepackage/contents/ui/ThumbnailsComponent.qml https://invent.kde.org/plasma/plasma-workspace/commit/89dce8a127a65844cd7a0ae71d185aba403fc4f6 |