| Summary: | Tab Browser theme broken with dark scheme | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | saif1988 |
| Component: | application | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | akashlj2, ccobj, christoph, janbidler00, jrb3218, serkonda7, vtrswm04381, waqar.17a |
| Priority: | NOR | ||
| Version: | 22.04.1 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/utilities/kate/commit/babf0b7084b509b140621faf627b58393bd89b2c | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | broken-tabs-bug | ||
|
Description
saif1988
2022-06-05 07:15:19 UTC
Confirmed. Maybe recreating the style on paletteChange would fix this, Unfortunately don't have a windows machine to fix this issue :( Yeah, recreating the style might really fix that. If we try that out in master, could you test this for us? Git commit 3014fe6af4c0cc8ba24ba937ab001b6fbe3652e7 by Christoph Cullmann. Committed on 12/06/2022 at 12:48. Pushed by cullmann into branch 'master'. re-instantiate style on palette changed M +16 -0 apps/lib/katetabbar.cpp https://invent.kde.org/utilities/kate/commit/3014fe6af4c0cc8ba24ba937ab001b6fbe3652e7 *** Bug 454092 has been marked as a duplicate of this bug. *** I tried commit c28e8175ff2575d6235780de0965745154118655 from the binary factory. A single "Tab" looks fine now, but multiple tabs are still broken. (And not sure if related to this patch, but if there's only one tab, I cannot double click to create other tabs, I have to go through file -> new) A possibly relevant merge request was started @ https://invent.kde.org/utilities/kate/-/merge_requests/774 Git commit babf0b7084b509b140621faf627b58393bd89b2c by Christoph Cullmann. Committed on 27/06/2022 at 13:58. Pushed by cullmann into branch 'master'. remove proxy style of avoid Windows issues let's try if without the proxy style the coloring is OK the only thing we loose is the italics M +0 -65 apps/lib/katetabbar.cpp https://invent.kde.org/utilities/kate/commit/babf0b7084b509b140621faf627b58393bd89b2c (In reply to Miepee from comment #6) > I tried commit c28e8175ff2575d6235780de0965745154118655 from the binary > factory. > A single "Tab" looks fine now, but multiple tabs are still broken. > (And not sure if related to this patch, but if there's only one tab, I > cannot double click to create other tabs, I have to go through file -> new) Hi, merged a new change, could you try out the next nightmake master compiles in the next days? I will, after binary factory will push out a new build. Currently its last build does not include that MR. A bit unrelated and too late now I assume, but I did have some questions regarding the MR in the Kate IRC/matrix room. Maybe I missed some other place where Kate discussions take place, but would be neat if those would be a bit more active :p Sorry, missed that. I don't think ATM the invent.kde.org CI works in that way to provide you the artifacts, I would assume this will be the case once one replaces binary-factory fully with it. But I might be wrong. *** Bug 456051 has been marked as a duplicate of this bug. *** > A bit unrelated and too late now I assume, but I did have some questions regarding the MR in the Kate IRC/matrix room. Maybe I missed some other place where Kate discussions take place, but would be neat if those would be a bit more active :p
Hi. It's not that its inactive, its that Telegram<->Matrix bridge is broken atm, so a lot of messages never get seen by some of the devs. Some of us are on Telegram, others on Matrix. If you use Telegram already, you can join the kateeditor group there.
Tested out the new MR, seems to work fine. It looks correct in both Breeze Light and Breeze Dark (I don't have any other Themes to test) and it properly shows on a changed-file-not-saved-to-disk tab via asterisk. *** Bug 456933 has been marked as a duplicate of this bug. *** *** Bug 457260 has been marked as a duplicate of this bug. *** *** Bug 457882 has been marked as a duplicate of this bug. *** *** Bug 458558 has been marked as a duplicate of this bug. *** |