| Summary: | 8dbec4a153be35bcab4a1877ee524a7cbcb72e84 inappropriately shows the user the "no password unlock" screen after they supply their fingerprint | ||
|---|---|---|---|
| Product: | [Plasma] kscreenlocker | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andrej, beojan, bhush94, darcagn, fabian, kde, notsyncing, postix, rafaeln.dev, thuryn1, timeygaming69 |
| Priority: | NOR | Keywords: | regression |
| Version: | 5.24.90 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/20c51d95798e953acd3299354a5b37a1216b6343 | Version Fixed In: | 5.26.4 |
|
Description
Nate Graham
2022-06-01 13:24:40 UTC
That's still better than what we had in 5.24 though? Indeed, it's better than what we had in 5.24, but it's worse than what we had in 5.25 prior to that commit. :) I see you removed the regression keyword (I guess because the better state that it's a regression from was never released to users), but regardless, I would really appreciate a quick fix because the current state is super annoying. :) What we had before 8dbec4a153be35bcab4a1877ee524a7cbcb72e84 was a very pleasant UX. *** Bug 455380 has been marked as a duplicate of this bug. *** For me the Unlock button then doesn't work, leaving me unable to unlock my session. (In reply to beojan from comment #5) > For me the Unlock button then doesn't work, leaving me unable to unlock my > session. You'll have to scan your finger multiple times, at least that's what worked for me. (In reply to timeygaming69 from comment #6) > (In reply to beojan from comment #5) > > For me the Unlock button then doesn't work, leaving me unable to unlock my > > session. > > You'll have to scan your finger multiple times, at least that's what worked > for me. This bug doesn't seem to be exclusive to fingerprint reader users only, though. I successfully enter my password and am left with an "unlock" button that does not work at all when clicked, meaning I'm completely unable to unlock my session. I have no fingerprint reader on this system. (In reply to darcagn from comment #7) > (In reply to timeygaming69 from comment #6) > > (In reply to beojan from comment #5) > > > For me the Unlock button then doesn't work, leaving me unable to unlock my > > > session. > > > > You'll have to scan your finger multiple times, at least that's what worked > > for me. > > This bug doesn't seem to be exclusive to fingerprint reader users only, > though. I successfully enter my password and am left with an "unlock" button > that does not work at all when clicked, meaning I'm completely unable to > unlock my session. I have no fingerprint reader on this system. That sounds more like bug 456639. (In reply to darcagn from comment #7) > (In reply to timeygaming69 from comment #6) > > (In reply to beojan from comment #5) > > > For me the Unlock button then doesn't work, leaving me unable to unlock my > > > session. > > > > You'll have to scan your finger multiple times, at least that's what worked > > for me. > > This bug doesn't seem to be exclusive to fingerprint reader users only, > though. I successfully enter my password and am left with an "unlock" button > that does not work at all when clicked, meaning I'm completely unable to > unlock my session. I have no fingerprint reader on this system. (In reply to beojan from comment #5) > For me the Unlock button then doesn't work, leaving me unable to unlock my > session. Same here on 5.25.0 with an unlock button which does nothing. And I found that when the unlock button appears, you can still scan a wrong finger for 3 times, then type your password(of course it won't show anything), then press enter, it will unlock. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2348 Git commit bd0c85460225ac91c469030ba05cf172a578fb80 by Nate Graham, on behalf of Janet Blackquill. Committed on 21/11/2022 at 15:49. Pushed by ngraham into branch 'master'. lockscreen: Consider info messages to be prompts The fingerprint message is delivered via this mechanism; using info messages in our heuristic will allow us to skip the Unlock button step for fingerprint users. M +1 -0 lookandfeel/org.kde.breeze/contents/lockscreen/LockScreenUi.qml https://invent.kde.org/plasma/plasma-workspace/commit/bd0c85460225ac91c469030ba05cf172a578fb80 Git commit 20c51d95798e953acd3299354a5b37a1216b6343 by Nate Graham, on behalf of Janet Blackquill. Committed on 21/11/2022 at 17:57. Pushed by ngraham into branch 'cherry-pick-bd0c8546'. lockscreen: Consider info messages to be prompts The fingerprint message is delivered via this mechanism; using info messages in our heuristic will allow us to skip the Unlock button step for fingerprint users. (cherry picked from commit bd0c85460225ac91c469030ba05cf172a578fb80) M +1 -0 lookandfeel/org.kde.breeze/contents/lockscreen/LockScreenUi.qml https://invent.kde.org/plasma/plasma-workspace/commit/20c51d95798e953acd3299354a5b37a1216b6343 |