| Summary: | The "Empty Grouping Plasmoid" and "Empty System Tray" options on the desktop "Add Panel" submenu that do nothing | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | zocsfxljsgpmiuaanz |
| Component: | Containment | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexander.lohnau, dev.bacteriostat, mkondarev, nate, notmart |
| Priority: | NOR | Keywords: | regression |
| Version: | 5.24.5 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/02287d5490e6fd4bcc4de9a88e614e8cb79176f8 | Version Fixed In: | 5.26 |
| Sentry Crash Report: | |||
| Attachments: | attachment-9687-0.html | ||
|
Description
zocsfxljsgpmiuaanz
2022-05-26 03:28:55 UTC
Can reproduce Operating System: Arch Linux KDE Plasma Version: 5.24.90 KDE Frameworks Version: 5.94.0 Qt Version: 5.15.4 Graphics Platform: Wayland Also confirmed. *** Bug 459388 has been marked as a duplicate of this bug. *** those plasmoids are technically containments but they are not supposed or supported to be used as panels, they are internal things that should never be user facing. simply they should not be listed there @Marco Should then only layout templates be listed there? Created attachment 152366 [details] attachment-9687-0.html Yes, I agree with that. Grouping Plasmoids is available as widget for desktop and System Tray is for panel. So these elements are not necessary in Add Panel. Am Freitag, September 23, 2022, 2:49 PM schrieb Marco Martin <bugzilla_noreply@kde.org>: https://bugs.kde.org/show_bug.cgi?id=454416 --- Comment #4 from Marco Martin <notmart@gmail.com> --- those plasmoids are technically containments but they are not supposed or supported to be used as panels, they are internal things that should never be user facing. simply they should not be listed there A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2160 A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/235 Git commit 30330a86bb9ade7e468780a3241a95636509142a by Nate Graham, on behalf of Marco Martin. Committed on 23/09/2022 at 16:16. Pushed by ngraham into branch 'master'. Remove ContainmentType from the grouping container plasmoid The grouping container plasmoid is *not* a containment, but is a normal applet that does some hack to display the contents of the internal grouping applet which *is* one. Since plasma-framework is built with if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 89) now everything that has the containmentype key is considered as a containment, and now the grouping plasmoid is listed in the "add panel" menu, however it doesn't really work there. that key was wrong from there to begin with. FIXED-IN: 5.26 M +0 -1 applets/grouping/container/package/metadata.json https://invent.kde.org/plasma/kdeplasma-addons/commit/30330a86bb9ade7e468780a3241a95636509142a Git commit dfab9de90dd311f9078d75369e849af424f47ae6 by Nate Graham, on behalf of Marco Martin. Committed on 23/09/2022 at 16:17. Pushed by ngraham into branch 'master'. Remove ContainmentType from the systray container plasmoid The systray container plasmoid is *not* a containment, but is a normal applet that does some hack to display the contents of the internal systray applet which *is* one. Since plasma-framework is built with if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 89) now everything that has the containmentype key is considered as a containment, and now the systray is listed in the "add panel" menu, however it doesn't really work there. that key was wrong from there to begin wwith. After some testing there doesn't seem to be any behavior difference of the systary plasmoid when used FIXED-IN: 5.26 M +0 -1 applets/systemtray/container/package/metadata.json https://invent.kde.org/plasma/plasma-workspace/commit/dfab9de90dd311f9078d75369e849af424f47ae6 Git commit 1eede278e43a85e4bb12b13cd4462eb8ec36698b by Nate Graham, on behalf of Marco Martin. Committed on 23/09/2022 at 16:17. Pushed by ngraham into branch 'Plasma/5.26'. Remove ContainmentType from the grouping container plasmoid The grouping container plasmoid is *not* a containment, but is a normal applet that does some hack to display the contents of the internal grouping applet which *is* one. Since plasma-framework is built with if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 89) now everything that has the containmentype key is considered as a containment, and now the grouping plasmoid is listed in the "add panel" menu, however it doesn't really work there. that key was wrong from there to begin with. FIXED-IN: 5.26 (cherry picked from commit 30330a86bb9ade7e468780a3241a95636509142a) M +0 -1 applets/grouping/container/package/metadata.json https://invent.kde.org/plasma/kdeplasma-addons/commit/1eede278e43a85e4bb12b13cd4462eb8ec36698b Git commit 02287d5490e6fd4bcc4de9a88e614e8cb79176f8 by Nate Graham, on behalf of Marco Martin. Committed on 23/09/2022 at 16:18. Pushed by ngraham into branch 'Plasma/5.26'. Remove ContainmentType from the systray container plasmoid The systray container plasmoid is *not* a containment, but is a normal applet that does some hack to display the contents of the internal systray applet which *is* one. Since plasma-framework is built with if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 89) now everything that has the containmentype key is considered as a containment, and now the systray is listed in the "add panel" menu, however it doesn't really work there. that key was wrong from there to begin wwith. After some testing there doesn't seem to be any behavior difference of the systary plasmoid when used FIXED-IN: 5.26 (cherry picked from commit dfab9de90dd311f9078d75369e849af424f47ae6) M +0 -1 applets/systemtray/container/package/metadata.json https://invent.kde.org/plasma/plasma-workspace/commit/02287d5490e6fd4bcc4de9a88e614e8cb79176f8 |