Bug 454286

Summary:	Allow using WIP translations
Product:	[Applications] krita	Reporter:	amyspark <amy>
Component:	G'Mic for Krita	Assignee:	amyspark <amy>
Status:	RESOLVED FIXED
Severity:	normal	CC:	thetwo222
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Compiled Sources
OS:	Microsoft Windows
URL:	https://github.com/amyspark/gmic/commit/d27138b48f61aae95f21857a08308e09d9235ee4
Latest Commit:	https://invent.kde.org/graphics/krita/commit/73fbcfb137b7a88e5b179fae7da9e4f238a8b109	Version Fixed In:
Attachments:	pic

Description amyspark 2022-05-23 16:38:31 UTC

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***
The patch that blocks mismatched translation loads mistakenly blocks using WIP translations (like zh_CN). I should re-enable that checkbox, if the user has a matching language they should be able to load matching WIP translators.

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 amyspark 2022-05-23 23:08:07 UTC

Fixed in the next tarball rollup. See attached commit.

Comment 2 Bug Janitor Service 2022-05-26 00:47:29 UTC

A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1459

Comment 3 amyspark 2022-05-26 14:27:35 UTC

Git commit 73fbcfb137b7a88e5b179fae7da9e4f238a8b109 by L. E. Segovia.
Committed on 26/05/2022 at 13:29.
Pushed by lsegovia into branch 'master'.

Update G'MIC to 3.1.2.2
Related: bug 453945, bug 453947, bug 453949, bug 454100

M  +2    -2    3rdparty_plugins/ext_gmic/CMakeLists.txt [INFRASTRUCTURE]

https://invent.kde.org/graphics/krita/commit/73fbcfb137b7a88e5b179fae7da9e4f238a8b109

Comment 4 thetwo 2022-06-03 12:55:45 UTC

Created attachment 149427 [details]
pic

krita-nightly-x64-5.1.0-prealpha-7768b6d0ca

In the version a few days ago, the translation works normally, but in today's nightly, it fails

Comment 5 amyspark 2022-06-03 12:57:32 UTC

Closing this bug again because no rollups of G'MIC 3.1.2 have been made since 3.1.2.2.

Comment 6 thetwo 2022-06-03 13:06:29 UTC

(In reply to amyspark from comment #5)
> Closing this bug again because no rollups of G'MIC 3.1.2 have been made
> since 3.1.2.2.

Sorry, I don't quite understand ......
In other words, is this not the time to test?
I saw that nightly merged some commits, so I did some testing and still have incorrect behavior so far. Do I need to wait a few days?

Comment 7 amyspark 2022-06-03 19:37:03 UTC

I keep the branch stable after a point release; in this case, I was working on stabilizing and cleaning the changes made by upstream to their translation management.

This one was a change that got lost in the cleanup, and was integrated in https://github.com/amyspark/gmic/commit/d27138b48f61aae95f21857a08308e09d9235ee4.  I hope to roll it up before we release 5.2, or when upstream releases 3.1.3, whichever happens first.