| Summary: | [5.24.90] [Regression] First character of password input to unlock session not registered | ||
|---|---|---|---|
| Product: | [Unmaintained] kscreenlocker | Reporter: | Richard Ullger <rullger> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | CC: | bshah, kde, nate, pepko94, philippe.roubach, postix |
| Priority: | VHI | Keywords: | regression |
| Version First Reported In: | 5.24.90 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/2e923593c065fa646626c3059ebfa202f1b7530e | Version Fixed In: | 5.25 |
| Sentry Crash Report: | |||
|
Description
Richard Ullger
2022-05-20 19:39:14 UTC
Can reproduce. Though I'm sure it worked fine when I did my refactors :/ Yet unsurprisingly bisect shows it's 3422348c5216078f598954c4b7c7e0fc902ce3b7 It's in onPromptForSecret:
mainBlock.mainPasswordBox.text = "";
This happens after the key to wake the screen. Not sure how to fix nicely neatly without breaking the hypothetical multi-prompt case. Worst case we can just remove for now.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1754 *** Bug 454147 has been marked as a duplicate of this bug. *** *** Bug 454328 has been marked as a duplicate of this bug. *** Git commit 74a80aaac78647c51662ca58e43078ef681059c3 by Nate Graham, on behalf of David Edmundson. Committed on 24/05/2022 at 19:53. Pushed by ngraham into branch 'master'. Lock screen: Avoid wiping password field when getting our first prompt When the lockscreen is in the screensaver mode we want the keyboard key pressed to wake the screen to go to the password box textfield. This did work correctly, but a code path also reset it when we get the first prompt. In the (currently hypothetical) case of multiple prompts we would want to clear anything in the prompt. This uses the existing boolean flag to handle that appropriately. M +9 -4 lookandfeel/contents/lockscreen/LockScreenUi.qml https://invent.kde.org/plasma/plasma-workspace/commit/74a80aaac78647c51662ca58e43078ef681059c3 Git commit 2e923593c065fa646626c3059ebfa202f1b7530e by Nate Graham, on behalf of David Edmundson. Committed on 24/05/2022 at 19:53. Pushed by ngraham into branch 'Plasma/5.25'. Lock screen: Avoid wiping password field when getting our first prompt When the lockscreen is in the screensaver mode we want the keyboard key pressed to wake the screen to go to the password box textfield. This did work correctly, but a code path also reset it when we get the first prompt. In the (currently hypothetical) case of multiple prompts we would want to clear anything in the prompt. This uses the existing boolean flag to handle that appropriately. (cherry picked from commit 74a80aaac78647c51662ca58e43078ef681059c3) M +9 -4 lookandfeel/contents/lockscreen/LockScreenUi.qml https://invent.kde.org/plasma/plasma-workspace/commit/2e923593c065fa646626c3059ebfa202f1b7530e *** Bug 454601 has been marked as a duplicate of this bug. *** Today there is an update of plasma 5.24.90, certainly about screen lock feature. Result: manually or automatically when the screen is locked we get a message saying locking failed, please open a text console with Ctrl_Alt_F2 then login then execute "loginctl unlock-session 2" then etc. I don't see any updates to Arch kde-unstable. I've manually applied the commit and it fixes the original problem and I'm not seeing your issue. Indeed, it's up to your distro to backport all fixes, and there's no guarantee that happened in the update you got. *** Bug 454784 has been marked as a duplicate of this bug. *** |