Bug 453994

Summary:	gap/spacing between desktops can't be configured anymore
Product:	[Plasma] kwin	Reporter:	bastimeyer123
Component:	effects-desktop-grid	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED INTENTIONAL
Severity:	normal	CC:	breakingspell, mabo, nate
Priority:	NOR	Keywords:	regression
Version First Reported In:	git master
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description bastimeyer123 2022-05-18 16:03:02 UTC

Initial report: BUG 453943

SUMMARY
After the recent QML rewrite of the desktopgrid effect, the gap/spacing between each desktop on the grid can't be configured anymore and it has been set to a constant value of `PlasmaCore.Units.largeSpacing`:
https://invent.kde.org/plasma/kwin/-/blob/master/src/effects/desktopgrid/qml/main.qml#L78-79

On certain grid configurations, this forced gap size can be very annoying and distracting and it should be configurable, like before with the old implementation of the grid effect.

See https://youtu.be/A0ydBC6tvUQ


STEPS TO REPRODUCE
1. set up a 2x2 or 3x3 grid
2. toggle desktopgrid


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.4


ADDITIONAL INFORMATION
- KWin built from 09ba8729fc12 (current master) using the modified PKGBUILD of the Arch repos
- kdecoration built from 4123ec8c1993 (current master) using the modified PKGBUILD of the Arch repos
- plasma-wayland-protocols built from 26fb07b9f8d3 (current master) using the modified PKGBUILD of the Arch repos
- the remaining dependencies were all from the official Arch repos

Comment 1 Nate Graham 2022-05-19 16:39:05 UTC

Can you provide an example of a configuration where the hardcoded spacing value is a problem?

Comment 2 bastimeyer123 2022-05-19 21:19:37 UTC

A 2x2 grid for example will always have a fat, thick bar in the middle of the screen, which is annoying and distracting.

I also don't like it. I was using a gap size of 1 for the past years and want to keep it like that. Adding gaps is pointless and doesn't look good. The user should have an option to change it.

Comment 3 Nate Graham 2022-05-23 14:30:48 UTC

I don't think this is a setting we're going to bring back, sorry. It seems like over-configurability. This small separation line between desktops isn't going to kill anyone. :)

Comment 4 Blazer Silving 2022-08-21 19:46:54 UTC

For bookkeeping here, i've opened an MR to address this border/spacing preference with a borderless toggle instead of a granular value as before: https://invent.kde.org/plasma/kwin/-/merge_requests/2806. 

Also, not the place for a discussion but:
>It seems like over-configurability
Being funny: If we're talking about over-configurability, let's look at the old Present Windows effect before it was reworked :) 

Being serious: Over-configurability out of the box is what gives KDE so much "ability" in my eyes over any other DE. Many settings could be streamlined and refactored, sure, like the simpler toggle I'm proposing for the grid width, but removing settings/preference ability and calling it a day isn't really cool. This was definitely a regression!

Being sentimental: For years I ran other DEs with Kwin_X11, just for the light-years-ahead effects and settings available in the compositor, and for the last 2 years it's been the entire KDE stack for me. I'm a fan of the Desktop Grid in particular and how it blew traditional multitasking out of the water, and still does even as we're building it back up after this QML rewrite. 
The QML rewrite's goal was to be as transparent as possible to the end user, and we're getting there, but I think every removed feature should be reconsidered if someone speaks up about it!