| Summary: | Can't open PlayListEntry 3-dot menu or hamburger menu from keyboard | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Jack Hill <jackhill3103> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | nate, trmdi |
| Priority: | NOR | Keywords: | regression, usability |
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/multimedia/elisa/commit/3b32d3fd6b8ec4a6ec032939edf76474e31e0606 | Version Fixed In: | 23.04 |
| Sentry Crash Report: | |||
|
Description
Jack Hill
2022-05-09 18:42:31 UTC
For that matter, the inline buttons lost keyboard-selectability too. Seems like a regression with the new UI. Git commit 9c8ab40946685adf2c64a4e75fb60b103b5c5a8b by Nate Graham, on behalf of Tranter Madi. Committed on 18/05/2022 at 19:57. Pushed by ngraham into branch 'master'. Fix playList's key navigation This fixes a recent regression and adds the ability to navigate between buttons with the arrow keys. FIXED-IN: 22.08 M +2 -2 src/qml/FlatButtonWithToolTip.qml M +40 -9 src/qml/MediaPlayListView.qml M +107 -85 src/qml/PlayListEntry.qml https://invent.kde.org/multimedia/elisa/commit/9c8ab40946685adf2c64a4e75fb60b103b5c5a8b Seems broken again Works for me. Note that you have to hit the return or enter key, since the spacebar is globally bound to "Play/Pause" irrespective of keyboard focus. Is this not working for you? Doesn't work in 22.12.01 or git master for me. Other buttons work though Actually I just realised that the PlayListEntry works, but the other menus don't (footer of Now Playing; footer of playlist; application menu). Can confirm that, but it's a separate issue. Can you file it? I suspect it''s related to using Kirigami.ActionToolBar for those buttons, which inherits the Qt default of activating buttons on space, not enter/return. (In reply to Nate Graham from comment #7) > Can confirm that, but it's a separate issue. Can you file it? I suspect > it''s related to using Kirigami.ActionToolBar for those buttons, which > inherits the Qt default of activating buttons on space, not enter/return. Will do, but I still can't open the hamburger menu Hamburger menu or 30-dot menu or both? Either way, those are different things and we need a different bug report for an issue with the hamburger menu vs the 3-dot menu. I can't open the hamburger menu or the 3-dot menus listed in bug 464160. The PlayListEntry 3-dot menu works fine. Can confirm that the hamburger menu is still broken. Broken by me recently in https://invent.kde.org/multimedia/elisa/-/commit/be5d35bf932235f010bff61c021ec17fe6a0ac69, because I switched those menu buttons' onClicked: handlers with onPressed:, but they inherit from a base control that sends the clicked() signal when triggered with return/enter. Need to fix that other one too. Git commit 3b32d3fd6b8ec4a6ec032939edf76474e31e0606 by Nate Graham. Committed on 12/01/2023 at 21:00. Pushed by ngraham into branch 'master'. Make menu buttons open on return/enter again Partially broken with be5d35bf932235f010bff61c021ec17fe6a0ac69. FIXED-IN: 23.04 M +11 -7 src/qml/MediaPlayerControl.qml M +13 -8 src/qml/NavigationActionBar.qml https://invent.kde.org/multimedia/elisa/commit/3b32d3fd6b8ec4a6ec032939edf76474e31e0606 |