| Summary: | Line selection: The blueish selection background may start later in case of smaller preview icons | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | postix <postix> |
| Component: | view-engine: details mode | Assignee: | Travis Burrows <tjburrows90> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | dolphin-bugs-null, felixernst, nate, postix, tjburrows90 |
| Priority: | NOR | Keywords: | junior-jobs |
| Version First Reported In: | 22.04.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| URL: | https://invent.kde.org/system/dolphin/-/merge_requests/389 | ||
| Latest Commit: | https://invent.kde.org/system/dolphin/commit/58622f431b0d7d347333a4bc7b2f57fe17878f9d | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
Screenshot
Screenshot 2 |
||
Created attachment 148384 [details]
Screenshot 2
It appears that the logic determining the rectangle size is found here: https://invent.kde.org/system/dolphin/-/blob/master/src/kitemviews/kstandarditemlistwidget.cpp#L498. Git commit 58622f431b0d7d347333a4bc7b2f57fe17878f9d by Felix Ernst, on behalf of Travis Burrows. Committed on 26/05/2022 at 12:38. Pushed by felixernst into branch 'master'. Extend selection rectangle to left edge This commit changes it so the sizes of selection rectangles and hover highlights in compact and details view mode is identical for all items. Before this commit, selection rectangles in lists would have varying indentation of the left edge of the selection rectangle depending on the preview image's width-to-height ratio. This would cause a sort of "ragged edge" in both compact and details list view when multiple items were selected. This commit doesn't change anything about icon view mode. M +10 -1 src/kitemviews/kstandarditemlistwidget.cpp https://invent.kde.org/system/dolphin/commit/58622f431b0d7d347333a4bc7b2f57fe17878f9d |
Created attachment 148383 [details] Screenshot SUMMARY Please see the screenshot. SOFTWARE/OS VERSIONS Operating System: openSUSE Tumbleweed 20220424 KDE Plasma Version: 5.24.4 KDE Frameworks Version: 5.93.0 Qt Version: 5.15.2 Kernel Version: 5.17.4-1-default (64-bit) Graphics Platform: Wayland