| Summary: | Investment Performance by Account Only Owned | ||
|---|---|---|---|
| Product: | [Applications] kmymoney | Reporter: | Peter Orczykowski <petero> |
| Component: | reports | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | ralf.habacker |
| Priority: | NOR | ||
| Version: | 5.1.2 | ||
| Target Milestone: | --- | ||
| Platform: | macOS (DMG) | ||
| OS: | macOS | ||
| Latest Commit: | https://invent.kde.org/office/kmymoney/-/commit/710581e2fb247734eb194811262d3f4edff6054e | Version Fixed In: | 5.2 |
| Sentry Crash Report: | |||
| Bug Depends on: | |||
| Bug Blocks: | 488491, 463974 | ||
| Attachments: |
Exhibit A
Exhibit B attachment-3583-0.txt Test.kmy Screenshot from previous major version ( Screenshot from previous major version (update) Test file (updated) |
||
|
Description
Peter Orczykowski
2022-04-17 08:29:23 UTC
Further, missing Dividends Paid Out affect performance figures. This should be seen as a critical bug now IMHO. The column not being displayed on the report is completely separate from whether or not the dividends are accounted for in performance figures. It would help a great deal if you could share a small test file demonstrating the problem, especially if the problem is more than simply a display issue. Created attachment 148276 [details]
Exhibit A
Created attachment 148277 [details]
Exhibit B
I have added two screen shots that clearly show the issue. Would that be sufficient? (In reply to Peter Orczykowski from comment #1) The screen shots show that the columns disappear, and I believe one of the developers already had a solution in mind for that issue. However, you claim that this affects performance figures. This is what we need a demonstration of. As I said in Comment #2, I do not believe that the missing columns have any effect on performance figures. Created attachment 148332 [details]
attachment-3583-0.txt
I have created a small test file with only one stock and few transactions. There are two saved reports under Favourite that show the issue,
Kind Regards,
Peter
Created attachment 148333 [details]
Test.kmy
Thanks, that is useful. I realize that the change in values is likely not because of the hidden columns, but due to differences in how the report is generated when limited to only owned. Now we just need to trace through the code to understand those differences. Created attachment 175700 [details]
Screenshot from previous major version (
In the previous major version of kmymoney the column "Dividends paid out" is included in the associated report.
Created attachment 175702 [details]
Screenshot from previous major version (update)
Screenshot from previous version updated with corrected date range
After looking at the code, I have to disagree with what has been stated in comment #2 and comment #9 above: it does make a difference if the column is included or not, at least for the totals. A possible change to adjust the code has been proposed on https://invent.kde.org/office/kmymoney/-/merge_requests/242. Created attachment 176134 [details]
Test file (updated)
I updated the test file to show associated values directly on opening the reports. Also reports has been added showing that the column "annualized return" depends on the date range of the report.
Git commit d14267d1ed0872c29b8e2617e3cc5ed310f16878 by Ralf Habacker. Committed on 02/12/2024 at 06:22. Pushed by habacker into branch 'master'. Correct name for column for IRR calculation in report code The column with the name ‘ctReturn’ actually contains the IRR value and is therefore renamed ‘ctInternalRateOfReturn’. The problem was found by Thomas Baumgart (see https://invent.kde.org/office/kmymoney/-/merge_requests/242#note_1083245). M +3 -3 kmymoney/plugins/views/reports/core/listtable.cpp M +1 -1 kmymoney/plugins/views/reports/core/listtable.h M +17 -25 kmymoney/plugins/views/reports/core/querytable.cpp M +3 -3 kmymoney/plugins/views/reports/core/tests/querytable-test.cpp https://invent.kde.org/office/kmymoney/-/commit/d14267d1ed0872c29b8e2617e3cc5ed310f16878 Git commit 2a9b7af9d7a9b1693836b6aa0a110c4962225380 by Ralf Habacker. Committed on 04/12/2024 at 10:19. Pushed by habacker into branch 'master'. Rename IRR-related enum and method to match what is actually calculated (XIRR) Fixup for commit d14267d1e M +3 -3 kmymoney/plugins/views/reports/core/listtable.cpp M +1 -1 kmymoney/plugins/views/reports/core/listtable.h M +16 -16 kmymoney/plugins/views/reports/core/querytable.cpp M +1 -1 kmymoney/plugins/views/reports/core/querytable.h M +3 -3 kmymoney/plugins/views/reports/core/tests/querytable-test.cpp https://invent.kde.org/office/kmymoney/-/commit/2a9b7af9d7a9b1693836b6aa0a110c4962225380 (In reply to Ralf Habacker from comment #15) > Rename IRR-related enum and method to match what is actually calculated > (XIRR) As it turned out that the output under the ‘annualised return’ actually corresponds to the XIRR value, a column for the output of the ‘annualised return’ with the correct calculation based on the ROI and the report time range was added with https://invent.kde.org/office/kmymoney/-/merge_requests/251. Git commit 710581e2fb247734eb194811262d3f4edff6054e by Ralf Habacker. Committed on 09/01/2025 at 00:02. Pushed by habacker into branch 'master'. Add missing column "Dividends paid out" Since the column was added to the calculation, it should also be displayed. FIXED-IN:5.2 M +4 -2 kmymoney/plugins/views/reports/core/querytable.cpp https://invent.kde.org/office/kmymoney/-/commit/710581e2fb247734eb194811262d3f4edff6054e |