Bug 452648

About System;
KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.93.0
Qt Version: 5.15.3
Graphics Platform: X11
wm: kwin_x11 vt: 1 dm: SDDM
Distro: Manjaro Linux base: Arch Linux

Graphics:
  Device-1: Intel 3rd Gen Core processor Graphics vendor: Dell driver: i915
    v: kernel ports: active: LVDS-1 empty: DP-1,HDMI-A-1,VGA-1 bus-ID: 00:02.0
    chip-ID: 8086:0166 class-ID: 0300
  Device-2: AMD Thames [Radeon HD 7500M/7600M Series] vendor: Dell
    driver: radeon v: kernel pcie: gen: 1 speed: 2.5 GT/s lanes: 8 link-max:
    gen: 2 speed: 5 GT/s lanes: 16 bus-ID: 01:00.0 chip-ID: 1002:6840
    class-ID: 0300
  Display: x11 server: X.Org v: 21.1.3 compositor: kwin_x11 driver: X:
    loaded: modesetting,radeon alternate: fbdev,vesa gpu: i915 display-ID: :0
    screens: 1
  Screen-1: 0 s-res: 1366x768 s-dpi: 96 s-size: 361x203mm (14.21x7.99")
    s-diag: 414mm (16.31")
  Monitor-1: LVDS-1 model: LG Display 0x033a built: 2012 res: 1366x768
    hz: 60 dpi: 101 gamma: 1.2 size: 344x194mm (13.54x7.64") diag: 395mm (15.5")
    ratio: 16:9 modes: 1366x768
  OpenGL: renderer: Mesa Intel HD Graphics 4000 (IVB GT2) v: 4.2 Mesa 22.0.1
    compat-v: 3.1 direct render: Yes

SUMMARY
after the upgrade to kde-frameworks-5.93 the all(system, brightness, volume) OSD indicators are displayed in the top left corner of the screen instead of being displayed in the center of the screen

STEPS TO REPRODUCE
invoke any changes through Fn keys  brightness, volume, Wifi, etc.

OBSERVED RESULT
the OSD indicator is displayed in the top left corner of the screen

EXPECTED RESULT
the OSD indicator should be displayed in the center of the screen

I can confirm that I have this same problem. Downgrading plasma-framework to 5.92.0 fixed it.

sometimes it fixes itself, and OSD begin appearing in the center again. just when, i wasnt able to determine. (could be if you meddle with volume changing function keys first)

The product for the bug should change to frameworks-plasma.

This commit introduces the bug. 

https://github.com/KDE/plasma-framework/commit/29d31c159503e454b3c483b0b7eb180ce0ee926a

Reverting it addresses the issue.

Specifically this part of the commit:

auto ret = QQuickWindow::event(event);
if (d->mainItem) {
    d->syncToMainItemSize();
}
 return ret;

I have also seen this occasionally

Can you confirm that b62d83bef7733e4943e6f66787166b41198d1359 doesn't address it?

With the commit b62d83bef7733e4943e6f66787166b41198d1359 applied to 5.93.0 he issue is still present.

Also the Archlinux 5.93.0 packet includes the b62d83bef7733e4943e6f66787166b41198d1359 commit as a patch.

Don't know if it helps but i believe that updateLayoutParameters() exits when it shouldn;t commenting out the return restores the expected behavior.

void DialogPrivate::updateLayoutParameters()
{
    if (!componentComplete || !mainItem || !mainItemLayout || q->visibility() == QWindow::Hidden)
        return;
    }

Cool, would you be able to submit a merge request with that change? Thanks!

Created attachment 148232 [details]
dialog patch

this patch fixes the problem for me, it reverts a part of 29d31c159503e454b3c483b0b7eb180ce0ee926a

Thanks, can you test some more on your system with various types of Plasma pop-ups, dialogs, and windows, and submit it at https://invent.kde.org/frameworks/plasma-framework/-/merge_requests?

shouldn't the guy that pushed this broken commit fix it? based on git it was Aleix Pol <aleixpol@kde.org>

That's not how the open-source world works. Anyone is allowed to fix anything. Sometimes the original author is busy at the moment and would appreciate help from the community. If you have a proposed fix, best to submit it!

to be honest, i just payed around with the patch and i'm not quite sure if it would be a better idea to just revert the whole commit

if someone can answer this, i can create a the invite stuff

Go ahead and submit it. Code review happens there, not here. :)

how do i create a merge request? I can only find a new button to create a new issue, checking out the source creating a new branch and trying to push the new branch leads to a

You are not allowed to push code to this project.

finished - https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/509

Thank you!

Git commit aec00b32980390b93411f140dfb0503a671c2163 by Aleix Pol Gonzalez, on behalf of Jim Jones.
Committed on 20/04/2022 at 16:18.
Pushed by apol into branch 'master'.

Fix osd dialog position

After the upgrade to kde-frameworks-5.93 the osd volume indicator is displayed in the top left corner of the screen instead of being displayed in the center of the screen.

M  +1    -5    src/plasmaquick/dialog.cpp

https://invent.kde.org/frameworks/plasma-framework/commit/aec00b32980390b93411f140dfb0503a671c2163

*** Bug 453443 has been marked as a duplicate of this bug. ***

*** Bug 477835 has been marked as a duplicate of this bug. ***

*** Bug 481723 has been marked as a duplicate of this bug. ***