Bug 451627

Summary:	Context menu styling is custom and does not come from the QStyle
Product:	[Frameworks and Libraries] frameworks-qqc2-desktop-style	Reporter:	Marco <phoenix_87_c>
Component:	general	Assignee:	Marco Martin <notmart>
Status:	CONFIRMED ---
Severity:	normal	CC:	4wy78uwh, ahiemstra, cocoathepenguin, kde, nate, noahadvs, random1123581321, uhhadd
Priority:	NOR
Version:	5.92.0
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=458201
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Example context menu in Elisa usina Breeze style, regardless of current theme.

Description Marco 2022-03-17 17:02:22 UTC

SUMMARY
Context menus in Slisa still use Breeze style, even when using a different applications style. The same happens with the recent plasma-systemsettings app, so this might be related to Kirigami or other frameworks these two applications use.

STEPS TO REPRODUCE
1. Change your applications style theme, e.g., with Kvantum
2. Open Elisa and show any of the context menus (e.g., hamburger menu)

OBSERVED RESULT
The menus still use the Breeze style.

EXPECTED RESULT
The menus should use the selected application style in system settings.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora 35,
KDE Plasma Version:  Plasma 5.24.3
KDE Frameworks Version: 5.92
Qt Version: 5.15.2

ADDITIONAL INFORMATION

Comment 1 Marco 2022-03-17 17:05:54 UTC

Created attachment 147564 [details]
Example context menu in Elisa usina Breeze style, regardless of current theme.

Comment 2 Nate Graham 2022-03-26 02:29:40 UTC

Yes, the menu item styling is hardcoded right now in the qqc2-desktop-style. If instead, it asked the QStyle to draw the menu graphics, then it would automatically inherit whatever styling that Kvantum applied.

Not sure how feasible that is.

Comment 3 Janet Blackquill 2022-03-26 03:49:17 UTC

In short: not really all that feasible. I'm sure there could be some sort of dark magic we could use, but it would probably break with a lot of apps and styles.

Comment 4 Nate Graham 2022-03-31 19:15:36 UTC

Darn.

It's a real issue though, so let's leave this bug report open in case we come up with any brilliant ideas to make it work.

Comment 5 Marco 2022-04-01 17:23:33 UTC

(In reply to Nate Graham from comment #4)
> Darn.
> 
> It's a real issue though, so let's leave this bug report open in case we
> come up with any brilliant ideas to make it work.

Yes I would say it is quite "serious" as it already affects a lot of applications (I started noticing it in Discover, system monitor, Kalendar, etc.) and considering that it seems KDE is moving towards refreshing most applications using this new framework, the issue will be more and more apparent.

Comment 6 Nate Graham 2022-06-21 17:43:44 UTC

*** Bug 455612 has been marked as a duplicate of this bug. ***

Comment 7 Nate Graham 2023-08-25 18:48:23 UTC

*** Bug 445639 has been marked as a duplicate of this bug. ***

Comment 8 Nate Graham 2023-08-25 18:52:05 UTC

One way to do this would be "simply" (lol) to implement Bug 458201.