Bug 449992

Summary: Checkbox and combobox labels elided in narrow mobile views
Product: [Applications] Elisa Reporter: Thomas Ramsauer <thomas.ramsauer>
Component: generalAssignee: Matthieu Gallien <matthieu_gallien>
Status: CONFIRMED ---    
Severity: normal CC: carl, jackhill3103, nate
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Android   
OS: Android 10.x   
See Also: https://bugs.kde.org/show_bug.cgi?id=450041
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: screenshot of behaviour
Setttings page on Android 13

Description Thomas Ramsauer 2022-02-11 07:25:05 UTC
Created attachment 146569 [details]
screenshot of behaviour

SUMMARY

The text of some dropdown menus in the settings are out of display bounds.


STEPS TO REPRODUCE
1. Open Elisa 
2. Go to settings 

OBSERVED RESULT
Not all text of dropdown menus and the specified folder path can be read.

EXPECTED RESULT
See all relevant text of dropdown menus and folder path
A scrolling mechanism (also for the specified folder path) or line wraping should be implemented.

SOFTWARE/OS VERSIONS
Android: LineageOS 17

ADDITIONAL INFORMATION
Elisa version is 21.07.70, installed from f-droid.
Comment 1 Nate Graham 2022-02-11 20:55:53 UTC
I can make the text elide rather than get cut off, but I can't make it wrap due to an issue in the generic checkbox control (See Bug 450041). I'll do what I can in Elisa itself, but we'll have to fix the rest in Bug 450041.
Comment 2 Nate Graham 2022-02-11 21:02:44 UTC
Git commit 7bed984da15a2fdb12b5a8dc3a4cb337b9ffb980 by Nate Graham.
Committed on 11/02/2022 at 21:01.
Pushed by ngraham into branch 'release/21.12'.

SettingsForm: Fill width with long UI controls

This way when the screen is narrow on mobile phones, the text elides
rather than being cut off.

M  +13   -0    src/qml/SettingsForm.qml

https://invent.kde.org/multimedia/elisa/commit/7bed984da15a2fdb12b5a8dc3a4cb337b9ffb980
Comment 3 Nate Graham 2022-02-11 21:03:40 UTC
The text will now elide rather than getting cut off with Elisa 21.12.3. Further improvements will require fixing Bug 450041, so I will mark this as a duplicate of that.

*** This bug has been marked as a duplicate of bug 450041 ***
Comment 4 Nate Graham 2022-09-19 22:12:14 UTC
So ultimately the problem here is twofold:
1. On Android, it uses the default Qt Material style by default, which has this problem.
2. Elisa doesn't force the usage of the qqc2-desktop style or breeze-desktop style, where it's already fixed.

We could conceivably fix #2 in Elisa, but #1 is a Qt bug that has to be fixed there.
Comment 5 Jack Hill 2023-05-03 16:13:58 UTC
Created attachment 158658 [details]
Setttings page on Android 13

Issue still partly occurs after the update to use Breeze theme. The checkbox text should flow onto the next line, imo. And the dropdown menu items are only as long as the dropdown box itself. Selecting a different item causes the box to elongate though.
Comment 6 Nate Graham 2023-05-05 06:19:21 UTC
Technically speaking, both of those issues are now bugs with the Breeze QQC2 style.

But ultimately probably the right solution is to port this window to use MobileForm, which presents a much more optimized layout for mobile and looks okay on the desktop too.