Summary: | XMI load in git version fails | ||
---|---|---|---|
Product: | [Applications] umbrello | Reporter: | Jessica <jess.jones.unitedkingdom> |
Component: | importer | Assignee: | Umbrello Development Group <umbrello-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | okellogg |
Priority: | NOR | ||
Version: | Git | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
Latest Commit: | 6085771b6d304d106f2582e316b8642d876be600 | Version Fixed In: | 2.33.80 (KDE releases 22.03.80) |
Attachments: | XMI file |
Description
Jessica
2022-01-30 22:44:46 UTC
The xmi file was made by importing python source code here: https://pacmancode.com/ Also when disabling "Enable UML2 support" the XMI file is not loaded. Current git b3c005b (KDE binary factory) doesn't load XMI file made with Umbrello 2.32. When "loading listview" , umbrello uses 9 GB (!) of RAM and windows says "the program doesn't respond". The file is never loaded no matter how long you wait. This has been fixed. (In reply to Oliver Kellogg from comment #4) > This has been fixed. On looking again, that is perhaps an oversimplification. "Fixed" just means that checks were added to refuse to set rogue x / y coordinate value on widgets. See bug 449622. Git commit fdbc8b6a972923e5f21e77c66a6630b97dbf3501 by Oliver Kellogg. Committed on 10/02/2022 at 19:43. Pushed by okellogg into branch 'master'. https://bugs.kde.org/show_bug.cgi?id=449393#c5 followup to commit 6085771 > "Fixed" just means that checks were added to refuse to set rogue x/y > coordinate value on widgets. umbrello/umlscene.{h,cpp} - Change the impl local static const maxCanvasSize to class level static s_maxCanvasSize. - Add getter maxCanvasSize() returning s_maxCanvasSize. umbrello/umlwidgets/umlwidget.cpp - In functions setX and setY, if the argument is below -maxCanvasSize() or above maxCanvasSize() then log an error and do not change the widget coordinate. M +5 -5 umbrello/umlscene.cpp M +4 -1 umbrello/umlscene.h M +8 -2 umbrello/umlwidgets/umlwidget.cpp https://invent.kde.org/sdk/umbrello/commit/fdbc8b6a972923e5f21e77c66a6630b97dbf3501 |