Summary: | When in tasks view, crash when selecting a specific calendar after having expanded the subtasks of a task | ||
---|---|---|---|
Product: | [Applications] Merkuro | Reporter: | Samuele <samuele.zappala> |
Component: | general | Assignee: | Claudio Cambra <claudio.cambra> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | carl, samuele.zappala |
Priority: | NOR | Keywords: | drkonqi |
Version First Reported In: | 0.4.0 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
New crash information added by DrKonqi
New crash information added by DrKonqi New crash information added by DrKonqi |
Description
Samuele
2022-01-24 11:25:33 UTC
We recently refactored the todo model, could you see if you can still reproduce this issue? Thanks! (In reply to Claudio Cambra from comment #1) > We recently refactored the todo model, could you see if you can still > reproduce this issue? Thanks! That is, if you can compile Kalendar from source, otherwise you might need to wait until the next release :) (In reply to Claudio Cambra from comment #2) > (In reply to Claudio Cambra from comment #1) > > We recently refactored the todo model, could you see if you can still > > reproduce this issue? Thanks! > > That is, if you can compile Kalendar from source, otherwise you might need > to wait until the next release :) I'll try to compile it from source and I'll let you know :) I'll try when I can reach the source code: https://invent.kde.org/pim/kalendar seems unavalilable. Couldn't compile, here's the error:
>CMake Error at /usr/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
> Could NOT find KF5 (missing: QQC2DesktopStyle) (found suitable version
> "5.90.0", minimum required is "5.88.0")
> Call Stack (most recent call first):
> /usr/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
> /usr/share/ECM/find-modules/FindKF5.cmake:93 (find_package_handle_standard_args)
> CMakeLists.txt:49 (find_package)
It seems 5.90 is less than 5.88. What am I doing wrong?
(In reply to Samuele from comment #5) > Couldn't compile, here's the error: > >CMake Error at /usr/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:230 (message): > > Could NOT find KF5 (missing: QQC2DesktopStyle) (found suitable version > > "5.90.0", minimum required is "5.88.0") > > Call Stack (most recent call first): > > /usr/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE) > > /usr/share/ECM/find-modules/FindKF5.cmake:93 (find_package_handle_standard_args) > > CMakeLists.txt:49 (find_package) > > It seems 5.90 is less than 5.88. What am I doing wrong? You are missing the package qqc2-desktop-style The name of the package I was missing is libkf5qqc2desktopstyle-dev, and it wasn't listed as a requirement in the project page. Anyway, I built it and tried again. As you can see here https://nextcloud.samuelezappala.it/s/mT4ELtPxCDGwrP8 if I'm in "All tasks" view, expand a task and then select a calendar, it just crashes. If I go from a calendar to an other it hangs and eventually Plasma asks me to close it. (In reply to Samuele from comment #7) > The name of the package I was missing is libkf5qqc2desktopstyle-dev, and it > wasn't listed as a requirement in the project page. > Anyway, I built it and tried again. As you can see here > https://nextcloud.samuelezappala.it/s/mT4ELtPxCDGwrP8 if I'm in "All tasks" > view, expand a task and then select a calendar, it just crashes. If I go > from a calendar to an other it hangs and eventually Plasma asks me to close > it. Thanks, will add this package to our README. This crash should be fixed now, could you test the latest commits from the git master version of Kalendar? Thanks again I tride commit 349c3066 and 6ebf38e9, the result is the same but I don't really understand what's happening: https://nextcloud.samuelezappala.it/s/qgTiAwD2WQpYAJS I'm sorry I couldn't attach a crash report, but the last thing I do (select a calendar different from the one in which the task I expanded is) just hangs the program. Created attachment 146056 [details]
New crash information added by DrKonqi
kalendar (0.4.0) using Qt 5.15.3
- What I was doing when the application crashed:
I succeded in making it crash again: changing task calendar was sufficient.
-- Backtrace (Reduced):
#4 0x00007fcdd800f2fc in KDescendantsProxyModel::mapFromSource (this=0x55f01aef0350, sourceIndex=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qmap.h:488
#5 0x00007fcdd80128ab in KDescendantsProxyModelPrivate::sourceRowsInserted (this=0x55f01aee3470, parent=..., start=0, end=17) at ./src/core/kdescendantsproxymodel.cpp:802
#6 0x00007fcdd640b19e in QtPrivate::QSlotObjectBase::call (a=0x7fff41aeba10, r=0x55f01aef0350, this=0x55f01af41420) at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#7 doActivate<false> (sender=0x55f01aef2830, signal_index=13, argv=0x7fff41aeba10) at kernel/qobject.cpp:3886
[...]
#9 0x00007fcdd63760b2 in QAbstractItemModel::rowsInserted (this=this@entry=0x55f01aef2830, _t1=..., _t2=<optimized out>, _t3=<optimized out>, _t4=...) at .moc/moc_qabstractitemmodel.cpp:592
(In reply to Samuele from comment #10) > Created attachment 146056 [details] > New crash information added by DrKonqi > > kalendar (0.4.0) using Qt 5.15.3 > > - What I was doing when the application crashed: > I succeded in making it crash again: changing task calendar was sufficient. > > -- Backtrace (Reduced): > #4 0x00007fcdd800f2fc in KDescendantsProxyModel::mapFromSource > (this=0x55f01aef0350, sourceIndex=...) at > /usr/include/x86_64-linux-gnu/qt5/QtCore/qmap.h:488 > #5 0x00007fcdd80128ab in KDescendantsProxyModelPrivate::sourceRowsInserted > (this=0x55f01aee3470, parent=..., start=0, end=17) at > ./src/core/kdescendantsproxymodel.cpp:802 > #6 0x00007fcdd640b19e in QtPrivate::QSlotObjectBase::call > (a=0x7fff41aeba10, r=0x55f01aef0350, this=0x55f01af41420) at > ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398 > #7 doActivate<false> (sender=0x55f01aef2830, signal_index=13, > argv=0x7fff41aeba10) at kernel/qobject.cpp:3886 > [...] > #9 0x00007fcdd63760b2 in QAbstractItemModel::rowsInserted > (this=this@entry=0x55f01aef2830, _t1=..., _t2=<optimized out>, > _t3=<optimized out>, _t4=...) at .moc/moc_qabstractitemmodel.cpp:592 Can you reproduce this crash when sorting your to-dos in ascending alphabetical order? Created attachment 146058 [details]
New crash information added by DrKonqi
kalendar (0.4.0) using Qt 5.15.3
- What I was doing when the application crashed:
Same crash, but with tasks sorted in alphabetical order.
-- Backtrace (Reduced):
#4 0x00007fa55d8612fc in KDescendantsProxyModel::mapFromSource (this=0x55fefb52f440, sourceIndex=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qmap.h:488
#5 0x00007fa55d8648ab in KDescendantsProxyModelPrivate::sourceRowsInserted (this=0x55fefb5225f0, parent=..., start=0, end=17) at ./src/core/kdescendantsproxymodel.cpp:802
#6 0x00007fa55bc5d19e in QtPrivate::QSlotObjectBase::call (a=0x7ffce8dc2d30, r=0x55fefb52f440, this=0x55fefb5804f0) at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#7 doActivate<false> (sender=0x55fefb531950, signal_index=13, argv=0x7ffce8dc2d30) at kernel/qobject.cpp:3886
[...]
#9 0x00007fa55bbc80b2 in QAbstractItemModel::rowsInserted (this=this@entry=0x55fefb531950, _t1=..., _t2=<optimized out>, _t3=<optimized out>, _t4=...) at .moc/moc_qabstractitemmodel.cpp:592
(In reply to Samuele from comment #12) > Created attachment 146058 [details] > New crash information added by DrKonqi > > kalendar (0.4.0) using Qt 5.15.3 > > - What I was doing when the application crashed: > Same crash, but with tasks sorted in alphabetical order. > > -- Backtrace (Reduced): > #4 0x00007fa55d8612fc in KDescendantsProxyModel::mapFromSource > (this=0x55fefb52f440, sourceIndex=...) at > /usr/include/x86_64-linux-gnu/qt5/QtCore/qmap.h:488 > #5 0x00007fa55d8648ab in KDescendantsProxyModelPrivate::sourceRowsInserted > (this=0x55fefb5225f0, parent=..., start=0, end=17) at > ./src/core/kdescendantsproxymodel.cpp:802 > #6 0x00007fa55bc5d19e in QtPrivate::QSlotObjectBase::call > (a=0x7ffce8dc2d30, r=0x55fefb52f440, this=0x55fefb5804f0) at > ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398 > #7 doActivate<false> (sender=0x55fefb531950, signal_index=13, > argv=0x7ffce8dc2d30) at kernel/qobject.cpp:3886 > [...] > #9 0x00007fa55bbc80b2 in QAbstractItemModel::rowsInserted > (this=this@entry=0x55fefb531950, _t1=..., _t2=<optimized out>, > _t3=<optimized out>, _t4=...) at .moc/moc_qabstractitemmodel.cpp:592 I was able to reproduce locally and have pushed a fix for the crashing, could you pull the latest changes again and check on your end? Thanks! Created attachment 146107 [details] New crash information added by DrKonqi kalendar (0.4.0) using Qt 5.15.3 Ok now all subtasks are expanded, without an option to make them collapsed by deafault, but this is clearly not important now. Going from "All tasks" to a specific calendar is not a problem anymore. I mean, the problem appeared expanding a task in its subtasks, but now it's all expanded; we can say that doiing the reverse (collapsing a task and selecting a specific calendar) doesn't create issues. The same with going from a calendar to another calendar: no issue anymore. But... - What I was doing when the application crashed: I managed to make it crash collapsing all the tasks in a specific calendar and changing calendar. i tried with the green calendar and it didn't happen; I don't know if it's related to calendar with more than a few tasks. You can see it happen here: https://nextcloud.samuelezappala.it/s/oTWSRsZQTSeP2BL -- Backtrace (Reduced): #4 0x00007feffe6fe2fc in KDescendantsProxyModel::mapFromSource (this=0x561221316590, sourceIndex=...) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qmap.h:488 #5 0x00007feffe7018ab in KDescendantsProxyModelPrivate::sourceRowsInserted (this=0x561221309760, parent=..., start=0, end=17) at ./src/core/kdescendantsproxymodel.cpp:802 #6 0x00007feffcafa19e in QtPrivate::QSlotObjectBase::call (a=0x7fffde901de0, r=0x561221316590, this=0x56122137dcf0) at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398 #7 doActivate<false> (sender=0x561221318ae0, signal_index=13, argv=0x7fffde901de0) at kernel/qobject.cpp:3886 [...] #9 0x00007feffca650b2 in QAbstractItemModel::rowsInserted (this=this@entry=0x561221318ae0, _t1=..., _t2=<optimized out>, _t3=<optimized out>, _t4=...) at .moc/moc_qabstractitemmodel.cpp:592 (In reply to Samuele from comment #14) > Created attachment 146107 [details] > New crash information added by DrKonqi > > kalendar (0.4.0) using Qt 5.15.3 > > Ok now all subtasks are expanded, without an option to make them collapsed > by deafault, but this is clearly not important now. > Going from "All tasks" to a specific calendar is not a problem anymore. I > mean, the problem appeared expanding a task in its subtasks, but now it's > all expanded; we can say that doiing the reverse (collapsing a task and > selecting a specific calendar) doesn't create issues. > The same with going from a calendar to another calendar: no issue anymore. > But... > > - What I was doing when the application crashed: > I managed to make it crash collapsing all the tasks in a specific calendar > and changing calendar. i tried with the green calendar and it didn't happen; > I don't know if it's related to calendar with more than a few tasks. > You can see it happen here: > https://nextcloud.samuelezappala.it/s/oTWSRsZQTSeP2BL > > -- Backtrace (Reduced): > #4 0x00007feffe6fe2fc in KDescendantsProxyModel::mapFromSource > (this=0x561221316590, sourceIndex=...) at > /usr/include/x86_64-linux-gnu/qt5/QtCore/qmap.h:488 > #5 0x00007feffe7018ab in KDescendantsProxyModelPrivate::sourceRowsInserted > (this=0x561221309760, parent=..., start=0, end=17) at > ./src/core/kdescendantsproxymodel.cpp:802 > #6 0x00007feffcafa19e in QtPrivate::QSlotObjectBase::call > (a=0x7fffde901de0, r=0x561221316590, this=0x56122137dcf0) at > ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398 > #7 doActivate<false> (sender=0x561221318ae0, signal_index=13, > argv=0x7fffde901de0) at kernel/qobject.cpp:3886 > [...] > #9 0x00007feffca650b2 in QAbstractItemModel::rowsInserted > (this=this@entry=0x561221318ae0, _t1=..., _t2=<optimized out>, > _t3=<optimized out>, _t4=...) at .moc/moc_qabstractitemmodel.cpp:592 Thank you for your patience and your dedication, it is seriously helpful. I've added a new and improved fix that should, fingers crossed, retain the prior behaviour of collapsed tasks by default while still preventing the crashing, including in the case you provided above. Could you try the latest commit? Thanks again! All seems well: no more crashes :D (In reply to Samuele from comment #16) > All seems well: no more crashes :D That's a relief -- very hapopy to close this bug now :) |