| Summary: | Notifications popup opens very small | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Nico <nico> |
| Component: | Notifications | Assignee: | Kai Uwe Broulik <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, plasma-bugs, sephiroth_pk |
| Priority: | HI | ||
| Version: | 5.23.90 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/843c5ae6df074dd0eb27fa773c3221b49555b4ff | Version Fixed In: | 5.24.1 |
| Sentry Crash Report: | |||
| Attachments: |
Screenshot of the popup
Screenshot after applying the patch Notifications are still broken in Plasma 5.24 Notifications applet with the correct size |
||
Let me know if you need any additional information regarding my setup I also noticed that it happens after resizing it, then receiving a notification, removing it from the history and opening it again after waiting some time. I think this is a consequential error though as it somehow resets the size to the original one and that one is wrong. Can reproduce. Seems fixable. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1362 Nice, thank you I will try the patch later today. Quick note what just came to my mind: Would it be possible to add an option to set the size when using notifications as a panel applet? This would make it possible to configure it like the notification sidebar in Windows 10. Git commit 9a6b190046a2db46523112da1af61be64c60d047 by Nate Graham. Committed on 17/01/2022 at 05:07. Pushed by ngraham into branch 'master'. applets/notifications: set implicit size Without this, the FullRepresentation opens to an unusably small size when it's a Panel applet. FIXED-IN: 5.24 M +4 -0 applets/notifications/package/contents/ui/FullRepresentation.qml https://invent.kde.org/plasma/plasma-workspace/commit/9a6b190046a2db46523112da1af61be64c60d047 Git commit 97d003374fbbc21f8e93b468aa96269637f6073b by Nate Graham. Committed on 17/01/2022 at 05:08. Pushed by ngraham into branch 'Plasma/5.24'. applets/notifications: set implicit size Without this, the FullRepresentation opens to an unusably small size when it's a Panel applet. FIXED-IN: 5.24 (cherry picked from commit 9a6b190046a2db46523112da1af61be64c60d047) M +4 -0 applets/notifications/package/contents/ui/FullRepresentation.qml https://invent.kde.org/plasma/plasma-workspace/commit/97d003374fbbc21f8e93b468aa96269637f6073b How did that regress? In the original implementation I made sure that it worked fine as a standalone panel applet. Created attachment 145963 [details]
Screenshot after applying the patch
Hm, I just looked, and I think it's still quite small. I liked the way it was in the old Plasma version. I still think an option to configure it would be best Created attachment 146526 [details]
Notifications are still broken in Plasma 5.24
The size currently set, 16 x 16, is still way too small and, in any case, much smaller than the applet was before. This makes notifications too dense and the messages scrollable; in other words, the applet is nigh unusable right now. Through some trial and error, and doing a comparison to another install that still has 5.23, I reconstructed that the previous size was 18 x 24.
Created attachment 146527 [details]
Notifications applet with the correct size
As already mentioned I agree with what Riccardo said. Perhaps I failed to understand the original issue but I don't see the problem in those screenshots. Can you clarify what exactly the issue is? The old size that the plasmoid, when it was open had, was much more reasonable. What was the old size, though? Maybe you can find a size that works for you by changing the implicitWidth and implicitHeight values in /usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/FullRepresentation.qml See if you can find the value that makes it the size it used to be. (In reply to Nate Graham from comment #16) > What was the old size, though? > > Maybe you can find a size that works for you by changing the implicitWidth > and implicitHeight values in > /usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/ > FullRepresentation.qml > > See if you can find the value that makes it the size it used to be. As I wrote in my previous message, I reconstructed the size to be 18 x 24. I manually edited `/usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/FullRepresentation.qml` to use 18 x 24, and I think it's much more reasonable. Would it make sense to add an option for it in the plasmoid settings? Seems like it does not already have settings. Git commit 928a2edbcb21c45170969ae2f4c9b14c167e8f31 by Nate Graham. Committed on 14/02/2022 at 17:27. Pushed by ngraham into branch 'master'. applets/notifications: Increase implicit size of standalone popup FIXED-IN: 5.24.1 M +2 -2 applets/notifications/package/contents/ui/FullRepresentation.qml https://invent.kde.org/plasma/plasma-workspace/commit/928a2edbcb21c45170969ae2f4c9b14c167e8f31 Git commit 843c5ae6df074dd0eb27fa773c3221b49555b4ff by Nate Graham. Committed on 14/02/2022 at 17:28. Pushed by ngraham into branch 'Plasma/5.24'. applets/notifications: Increase implicit size of standalone popup FIXED-IN: 5.24.1 (cherry picked from commit 928a2edbcb21c45170969ae2f4c9b14c167e8f31) M +2 -2 applets/notifications/package/contents/ui/FullRepresentation.qml https://invent.kde.org/plasma/plasma-workspace/commit/843c5ae6df074dd0eb27fa773c3221b49555b4ff |
Created attachment 145423 [details] Screenshot of the popup SUMMARY Notifications popup opens very small STEPS TO REPRODUCE Not sure on which occasions this happens, but I'm going to describe my Panel setup 1. Create a top panel containing Applets: Kickoff, Window Title, Global Menu, Flexible spacer, System Tray, KDE Connect, Networks, Volume, Digital Clock, Notifications 2. Configure System Tray > Entries > Notifications > Disabled 3. (Maybe restart Plasma) 4. Click on the notifications plasmoid OBSERVED RESULT Opens up very small (see screenshot) (Can be resized with Meta+Right click drag) EXPECTED RESULT Open with a normal size, like before SOFTWARE/OS VERSIONS Linux/KDE Plasma: KDE Plasma Version: 5.23.90 KDE Frameworks Version: 5.90.0 Qt Version: 5.15.12 ADDITIONAL INFORMATION