| Summary: | After update to frameworks 5.90, .desktop files with paths to SVG icons fail to display them | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | KIO Bugs <kio-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | elman, kdelibs-bugs, l.arvanitis, nate, plasma-bugs, qydwhotmail, realnc |
| Priority: | NOR | Keywords: | regression |
| Version: | 5.90.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=448596 | ||
| Latest Commit: | https://invent.kde.org/frameworks/kio/commit/25b470d4381aabfdeb76b9c7110c8091808c78dd | Version Fixed In: | 5.91 |
| Sentry Crash Report: | |||
| Attachments: |
frameworks 5.89
after update to frameworks 5.90 SVG icon |
||
|
Description
Patrick Silva
2022-01-08 14:57:31 UTC
Created attachment 145223 [details]
after update to frameworks 5.90
I don't really want to download a whole app, can you show me the .desktop file. If there is an Icon= line can you upload that. frameworks 5.90 was moved to stable repo today and now I'm unable to reproduce. Created attachment 145302 [details]
SVG icon
Nevermind. Frameworks was partially updated yesterday, the rest was updated today and the bug is back.
SVG icon attached.
Contents of the .desktop file: #!/usr/bin/env xdg-open [Desktop Entry] Name=BiglyBT GenericName=BitTorrent Client Exec=/home/stalker/biglybt/biglybt %U Icon=/home/stalker/biglybt/biglybt.svg Terminal=false Type=Application MimeType=x-scheme-handler/magnet;application/x-bittorrent;application/x-biglybt;x-scheme-handler/biglybt; Categories=Application;Network;FileTransfer;P2P;GTK;Java; StartupWMClass=BiglyBT I can confirm that paths to SVG files fail. If I make a dummy desktop file with this in it, it fails: > Icon=/home/nate/kde/usr/share/icons/breeze/categories/32/applications-games.svg But it works if I change it to: > Icon=applications-games The issue won't be in plasmashell, but I don't know where to move the bug report to. The issue could be in KDirModel. Investigating... The culprit could be https://invent.kde.org/frameworks/kio/-/merge_requests/688 But in 5.89 I don't know why it works. KIconUtils::addOverlays still used `QIcon::fromTheme`. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/708 *** Bug 448883 has been marked as a duplicate of this bug. *** Git commit 25b470d4381aabfdeb76b9c7110c8091808c78dd by Fushan Wen. Committed on 23/01/2022 at 09:33. Pushed by ahmadsamir into branch 'master'. kdirmodel: Allow using full path for Icon in .desktop file This allows KDirModel correctly shows the icon with a full path specified in the .desktop file. Related: bug 448596 M +14 -1 src/widgets/kdirmodel.cpp https://invent.kde.org/frameworks/kio/commit/25b470d4381aabfdeb76b9c7110c8091808c78dd Git commit 672c743000d1a9a97ccf6e88f89552a744010edd by Fushan Wen. Committed on 23/01/2022 at 09:34. Pushed by ahmadsamir into branch 'master'. autotests: Add `testIcon` to kdirmodeltest The test can validate the correct icon is used if "Icon" is specified in the desktop file, and can fall back to "unknown" if KDirModel fails to load the icon. Related: bug 448596 M +136 -0 autotests/kdirmodeltest.cpp M +7 -0 autotests/kdirmodeltest.h https://invent.kde.org/frameworks/kio/commit/672c743000d1a9a97ccf6e88f89552a744010edd *** Bug 449231 has been marked as a duplicate of this bug. *** |