Bug 447965

Summary: OverlaySheet's scrim is not effective in highlighting the sheet when using a dark color scheme
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Edward Oubrayrie <edoubrayrie>
Component: generalAssignee: Marco Martin <notmart>
Status: CONFIRMED ---    
Severity: normal CC: cyslider, edoubrayrie, nate
Priority: NOR Keywords: usability
Version First Reported In: 5.90.0   
Target Milestone: Not decided   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Auto-revert window
Auto-revert window plasma 5.23.90

Description Edward Oubrayrie 2022-01-05 09:34:29 UTC
Created attachment 145124 [details]
Auto-revert window

SUMMARY

the new (~Plasma 5.23) "Keep display configuration" auto-revert window is a usability nightmare for me. I forget to click it about 95% of the time. It's certainly my fault but:

* It has incredibly low visibility (especially with the dark theme): very small, 0 contrast with the background "Display Configuration" window
* It is on only one screen (so, since it will move around during apply (which is the point) it's usually not in front of my eyes anymore.
* It does not stay on top (maybe related to Wayland limited capabilities on that front, but I'm on X11), and does not prevent me from working happily... during 1 minute of course.

STEPS TO REPRODUCE
1.  Open display settings
2.  Chamge
3. Apply

OBSERVED RESULT
Auto-revert windows is easy to miss and easy to ignore.

EXPECTED RESULT
Auto-revert windows is *impossible* to miss and *hard* to ignore.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE neon 20.04
KDE Plasma Version: 4:5.23.1+p20.04+tstable+git20211023.0054-0
KDE Frameworks Version: 5.87.0+p20.04+tunstable+git20211010.0149-0
Qt Version: 5.15.2+p20.04+tunstable+git20211024.0137-0
Comment 1 Nate Graham 2022-01-12 20:24:06 UTC
Fixed in Plasma 5.24 already by darkening the background behind the dialog.
Comment 2 Edward Oubrayrie 2022-01-18 14:21:07 UTC
Created attachment 145616 [details]
Auto-revert window plasma 5.23.90

> Fixed in Plasma 5.24 already by darkening the background behind the dialog.

That's great news but I don't see anything like on latest testing packages, is it Wayland-only? Can you point to relevant MR or version? 

(It's unclear with Neon's package versioning but "About" says I'm on the 5.24 beta...)

Operating System: KDE neon Testing Edition
KDE Plasma Version: 5.23.90
KDE Frameworks Version: 5.91.0
Qt Version: 5.15.3
Kernel Version: 5.8.0-59-generic (64-bit)
Graphics Platform: X11
kscreen        4:5.23.5+p20.04+tstable+git20220113.1818-0 amd64
Comment 3 Nate Graham 2022-01-18 20:33:28 UTC
OK, yeah, I can see that the darkening scrim is not very dark indeed.

Looks like this is a general issue with Kirigami.OverlaySheet.
Comment 4 Nate Graham 2023-01-04 19:42:57 UTC
*** Bug 463108 has been marked as a duplicate of this bug. ***