Bug 447403

Summary:	Make it more obvious which repo an install is coming from
Product:	[Applications] Discover	Reporter:	Reuben <kde>
Component:	discover	Assignee:	Dan Leinir Turthra Jensen <leinir>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	aleixpol, nate
Priority:	NOR	Keywords:	usability
Version:	5.23.4
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/discover/commit/862a1f5a7762bdb681567556df577555718889cb	Version Fixed In:	5.25
Sentry Crash Report:

Description Reuben 2021-12-23 01:00:38 UTC

PPAs are for better or worse widespread. (To my understanding) if a PPA were to be compromised, an attacker could introduce packages outside of the core scope of the PPA (e.g. somebody could introduce a backdoored version of systemd via a pipewire PPA). For this reason, it'd be useful if Discover shows which repo a package update is coming from, to give the user a chance to see something unusual.

Comment 1 Nate Graham 2022-01-11 23:11:27 UTC

It does tell you that, right in the "Source" row at the bottom of the page.

Comment 2 Reuben 2022-01-11 23:39:12 UTC

Ah, I see it. Then could we change this to: "Request: move source above the description in the discover package details"? Rationale: it's important to know if a PPA is giving you a core package. Description could easily push source below the fold, as of course could the reviews.

Comment 3 Nate Graham 2022-01-13 18:18:54 UTC

Sure, seems reasonable.

Comment 4 Bug Janitor Service 2022-01-31 01:06:54 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/246

Comment 5 Nate Graham 2022-02-04 16:03:34 UTC

Git commit 862a1f5a7762bdb681567556df577555718889cb by Nate Graham.
Committed on 04/02/2022 at 02:49.
Pushed by ngraham into branch 'master'.

Overhaul app page

With VDG guidance and mockups, this commit aims to increase the
aesthetic qualities and usefulness of the Application page in the
following ways:

- Move all the metadata from their rather hidden location on the bottom
  of the page to much higher up on the page in a new layout
- Add a defined header area that contains entirely informational
  metadata and screenshots
- Make all the actionable metadata (e.g. "read documentation," "visit
  homepage," "report bug") into buttons
- Improve the license display by only showing the first two when there
  are a lot, with a "show more" button to see them all
- Make the main content area centered rather than left-aligned when the
  page is wide enough to have the content area's maximum width limited
Related: bug 438920
FIXED-IN: 5.25

M  +429  -189  discover/qml/ApplicationPage.qml
M  +1    -1    discover/qml/ApplicationScreenshots.qml
M  +1    -1    libdiscover/resources/AbstractResource.cpp

https://invent.kde.org/plasma/discover/commit/862a1f5a7762bdb681567556df577555718889cb