| Summary: | Import from Discogs not fetching 'Catalog Number' tag | ||
|---|---|---|---|
| Product: | [Applications] kid3 | Reporter: | vvkanz |
| Component: | general | Assignee: | Urs Fleisch <ufleisch> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 3.9.x | ||
| Target Milestone: | --- | ||
| Platform: | macOS (DMG) | ||
| OS: | macOS | ||
| Latest Commit: | https://invent.kde.org/multimedia/kid3/commit/b42118f59e01f254ce12627b937e9db8d4f5fbf4 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
vvkanz
2021-12-21 09:26:21 UTC
I am sorry to hear that the new release has not met your expectations. Could you please elaborate a bit more detailed what is expected and what is received, if possible with a link to the Discogs URL of one or more albums. Unfortunately, the "standard" Discogs import is rather shaky because it depends on the HTML output coming from the Discogs server, and this output is changing a lot. I stopped counting how many commits with description "Fix Discogs import" I had to make in the past. Have you tried the JSON API import? It is stable and uses the official Discogs API. You just have to get register at Discogs.com, get an API token, enter it in Kid3's Discogs import dialog and click "Save Settings" (this is described in the handbook). Maybe this will bring you the catalog numbers you are expecting. (In reply to Urs Fleisch from comment #1) > I am sorry to hear that the new release has not met your expectations. Could > you please elaborate a bit more detailed what is expected and what is > received, if possible with a link to the Discogs URL of one or more albums. > > Unfortunately, the "standard" Discogs import is rather shaky because it > depends on the HTML output coming from the Discogs server, and this output > is changing a lot. I stopped counting how many commits with description "Fix > Discogs import" I had to make in the past. > > Have you tried the JSON API import? It is stable and uses the official > Discogs API. You just have to get register at Discogs.com, get an API token, > enter it in Kid3's Discogs import dialog and click "Save Settings" (this is > described in the handbook). Maybe this will bring you the catalog numbers > you are expecting. Yes, it worked with the token! Thank you very much, Urs! Git commit b42118f59e01f254ce12627b937e9db8d4f5fbf4 by Urs Fleisch. Committed on 25/12/2021 at 11:25. Pushed by ufleisch into branch 'master'. Fix Discogs import to find correct release M +36 -11 src/plugins/discogsimport/discogsimporter.cpp https://invent.kde.org/multimedia/kid3/commit/b42118f59e01f254ce12627b937e9db8d4f5fbf4 I found a problem in the "standard" Discogs import, the one which is not using the API token. Could you test if the catalog numbers are imported correctly also without an API token? You can find the fixed version git20211225 in the development folder https://sourceforge.net/projects/kid3/files/kid3/development/. (In reply to Urs Fleisch from comment #4) > I found a problem in the "standard" Discogs import, the one which is not > using the API token. Could you test if the catalog numbers are imported > correctly also without an API token? You can find the fixed version > git20211225 in the development folder > https://sourceforge.net/projects/kid3/files/kid3/development/. Yes, in this version (git20211225) the catalog number are imported correctly in the standard import (without the token). |