Summary: | Metadata filter in metadata tab | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | herb <herb.k> |
Component: | Setup-Metadata | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | metzpinguin |
Priority: | NOR | ||
Version: | 7.4.0 | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
Latest Commit: | https://invent.kde.org/graphics/digikam/commit/403e9dd2a6ac3e0532564765c36b35f5c441fae8 | Version Fixed In: | 7.4.0 |
Description
herb
2021-12-05 18:37:26 UTC
This is so desired, you have to select all metadata you want to see in the custom filter. Maik If no metadata tags have been selected, the filter is deactivated and all are displayed. Maik Hello, thanks for your quick replies. I think the goal I want to reach is misunderstood. For me it confuses the user - when "Custom" filter is selected - but NO tag is assigned in settings - and ALL metadata are displayed - which is "No Filter" selection for me. Ok, this is design decision - BUT in this case "No Filter" should be marked with the bullet marker For me the error is that "Custom" is marked with the bullet. I hope, I described my goal clear enough. Thanks in advance herb Well, I already understand your problem. The custom filter does not lead to misunderstandings for the first time, see bug 370491. I still find it unnecessary to deactivate the custom filter because it has the same setting as no filter. What if the custom filter happens to have the same settings as the photo filter? There is then no change in the metadata display when the filter is changed. And what if the custom filter was selected and the settings are cleared, then the custom filter is grayed out but still selected. Then switching to no filter could also be confusing. Maik Hello, thanks for your comments. But sorry Sir, I do not fully agree: "No Filter" is all tags to be displayed. "Photograph" is an internally defined filter. "Custom" is an user-defined filter. (1) Well, when "Custom" is identical to "Photograph" and when user changes from one to the other there is no change of displayed metadata; I agree; but marked with the bullet is that filter, that has been selected by user. (2) When in settings for "Custom" NO tag is selected, then - for my understanding - NO tag should be displayed. OK, your design is to display all tags in that case; For me it is a NoGo to mark "Custom" with the bullet and display ALL="No Filter". Sorry. Best regards herb Git commit 403e9dd2a6ac3e0532564765c36b35f5c441fae8 by Maik Qualmann. Committed on 06/12/2021 at 21:32. Pushed by mqualmann into branch 'master'. disable custom filter action if no custom metadata tags selected FIXED-IN: 7.4.0 M +1 -1 NEWS M +15 -0 core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp M +15 -0 core/libs/widgets/metadata/exiv2/metadatawidget.cpp https://invent.kde.org/graphics/digikam/commit/403e9dd2a6ac3e0532564765c36b35f5c441fae8 Hello, Thanks for this correction. Best regards herb |