Summary: | The status bar does not show the brush preset with a new or switched document | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Ahab Greybeard <ahab.greybeard> |
Component: | Usability | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | lynx.mw+kde |
Priority: | NOR | Keywords: | regression |
Version: | nightly build (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Debian stable | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/graphics/krita/commit/a41f52e52243583045786bad0833c23eef017e91 | Version Fixed In: | |
Sentry Crash Report: |
Description
Ahab Greybeard
2021-12-01 20:02:27 UTC
It pretty sure is a regression from "Set the current preset on the statusbar from KisPaintOpBox" to fix bug 441751. When switching canvas, tools get pretty much completely reset, and part of that is clearing the status text on deactivation. I tried to understand what "Doing so from the canvas resource managers runs into the signal rate limiter." means, but I can't find anything that would limit the update rate from KoCanvasResourceManager => KoToolManager => KisStatusBar. Git commit fa8f5cdf275db9160339d39272287652422f04dc by Dmitry Kazakov. Committed on 17/12/2021 at 13:52. Pushed by dkazakov into branch 'master'. Revert "Set the current preset on the statusbar from KisPaintOpBox" This reverts commit 9202fb2d4e07dfbe5dcd8f005159014ce3df13ea. The original bug this commit fixed seem to have been caused by some slow loading of the resources, which is now fixed. And the commit itself introduces status bar update bugs. Related: bug 441751 M +0 -4 libs/ui/kis_paintop_box.cc M +0 -5 libs/ui/kis_statusbar.cc M +0 -2 libs/ui/kis_statusbar.h M +1 -0 libs/ui/kis_zoom_manager.cc M +4 -0 libs/ui/tool/kis_tool.cc M +5 -0 libs/ui/tool/kis_tool_paint.cc https://invent.kde.org/graphics/krita/commit/fa8f5cdf275db9160339d39272287652422f04dc Git commit a41f52e52243583045786bad0833c23eef017e91 by Dmitry Kazakov. Committed on 17/12/2021 at 13:53. Pushed by dkazakov into branch 'krita/5.0'. Revert "Set the current preset on the statusbar from KisPaintOpBox" This reverts commit 9202fb2d4e07dfbe5dcd8f005159014ce3df13ea. The original bug this commit fixed seem to have been caused by some slow loading of the resources, which is now fixed. And the commit itself introduces status bar update bugs. Related: bug 441751 (cherry picked from commit fa8f5cdf275db9160339d39272287652422f04dc) M +0 -4 libs/ui/kis_paintop_box.cc M +0 -5 libs/ui/kis_statusbar.cc M +0 -2 libs/ui/kis_statusbar.h M +1 -0 libs/ui/kis_zoom_manager.cc M +4 -0 libs/ui/tool/kis_tool.cc M +5 -0 libs/ui/tool/kis_tool_paint.cc https://invent.kde.org/graphics/krita/commit/a41f52e52243583045786bad0833c23eef017e91 |