Summary: | KDE Connect KCM launched via system tray applet should open inside System Settings | ||
---|---|---|---|
Product: | [Applications] kdeconnect | Reporter: | Patrick Silva <bugseforuns> |
Component: | plasmoid | Assignee: | Phani Pavan K <kphanipavan> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kphanipavan, nate, nicolas.fella, plasma-bugs |
Priority: | NOR | Keywords: | junior-jobs |
Version First Reported In: | 23.04.0 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/network/kdeconnect-kde/-/commit/c5b955fe10173d390150ceeee8d15b64894fc167 | Version Fixed In: | |
Sentry Crash Report: |
Description
Patrick Silva
2021-12-01 19:42:33 UTC
It would be easy enough to make the applet run KCMshell.openSystemSettings("kcm_kdeconnect.desktop"), but currently it calls out to a common C++ function, so that should be changed instead, in https://invent.kde.org/network/kdeconnect-kde/-/blob/master/core/daemon.cpp#L336. Currently it just uses QProcess::startDetached(); BooOOoooOoOoooooooooo The standalone window is there so we can use the KCM on Windows, MacOS, Gnome... I'm not against opening System Settings as long as we have a check to only do it when running Plasma. A possibly relevant merge request was started @ https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/576 Git commit c5b955fe10173d390150ceeee8d15b64894fc167 by Albert Vaca Cintora, on behalf of Phani Pavan Kambhampati. Committed on 30/07/2023 at 09:30. Pushed by albertvaka into branch 'master'. Changed KCM to launch in system settings KCM used to open in a separate window, changed that behaviour to launch in system settings when launched via the plasmoid. M +1 -1 plasmoid/package/contents/ui/FullRepresentation.qml M +1 -1 plasmoid/package/contents/ui/main.qml https://invent.kde.org/network/kdeconnect-kde/-/commit/c5b955fe10173d390150ceeee8d15b64894fc167 |