Bug 446105

Summary:	Toggling "Only group when Task Manager is full" will make the height of textual list 1px
Product:	[Plasma] plasmashell	Reporter:	Fushan Wen <qydwhotmail>
Component:	Task Manager and Icons-Only Task Manager widgets	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate, plasma-bugs-null
Priority:	NOR
Version First Reported In:	master
Target Milestone:	1.0
Platform:	openSUSE
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=445848 https://bugs.kde.org/show_bug.cgi?id=446108
Latest Commit:	https://invent.kde.org/plasma/plasma-desktop/commit/05efb051608d7f3467c1fb5e0510d7de13ca6dbc	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Bug.mp4

Description Fushan Wen 2021-11-26 08:15:24 UTC

SUMMARY
Similar to https://bugs.kde.org/show_bug.cgi?id=445848

STEPS TO REPRODUCE
1. Restart plasmashell
2. Enter Edit Mode
3. Edit Task Manager and enable "Only group when Task Manager is full", then apply.
4. Edit Task Manager and disable "Only group when Task Manager is full", then apply.
5. Exit Edit Mode

OBSERVED RESULT
The height of textual list becomes 1px

EXPECTED RESULT
Normal height

SOFTWARE/OS VERSIONS
X11

Comment 1 Fushan Wen 2021-11-26 08:44:11 UTC

I find out the real cause: groupDialog.visualParent.itemIndex is not updated if the index of a task is changed.

Comment 2 Bug Janitor Service 2021-11-26 09:44:14 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/716

Comment 3 Fushan Wen 2021-11-26 12:43:25 UTC

Created attachment 143964 [details]
Bug.mp4

Comment 4 Nate Graham 2021-11-29 20:05:48 UTC

Git commit 05efb051608d7f3467c1fb5e0510d7de13ca6dbc by Nate Graham, on behalf of Fushan Wen.
Committed on 29/11/2021 at 20:00.
Pushed by ngraham into branch 'master'.

taskmanager: Replace count with groupFilter.count for groupListView

Use groupFilter.count because sometimes groupFilter.count is updated in
time but count is not, so no more 1px bug will occur again.

M  +2    -1    applets/taskmanager/package/contents/ui/GroupDialog.qml

https://invent.kde.org/plasma/plasma-desktop/commit/05efb051608d7f3467c1fb5e0510d7de13ca6dbc