| Summary: | Logout screen button animations aren't right | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | pbs3141 |
| Component: | Theme - Breeze | Assignee: | visual-design |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, plasma-bugs |
| Priority: | NOR | ||
| Version First Reported In: | 5.23.3 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/747076d71262bea04c9ee9d2b971ed7b36141b23 | Version Fixed In: | 5.24 |
| Sentry Crash Report: | |||
Can confirm. Git commit 747076d71262bea04c9ee9d2b971ed7b36141b23 by Nate Graham. Committed on 01/12/2021 at 04:37. Pushed by ngraham into branch 'master'. LogoutButton: fix janky animation Use a PropertyAnimation instead of an OpacityAnimator, as ActionButton itself does. This fixes weird animation jumpiness on hover. FIXED-IN: 5.24 M +1 -1 lookandfeel/contents/logout/LogoutButton.qml https://invent.kde.org/plasma/plasma-workspace/commit/747076d71262bea04c9ee9d2b971ed7b36141b23 |
Description When I zip my mouse cursor over the buttons in the logout screen too fast, their opacity jumps to zero then animates back to 0.5. The opacity should not leave the range [0.5, 1] and also shouldn't jump. Fix In ActionButton.qml https://github.com/KDE/plasma-workspace/blob/91909b577045b2e347033a557d0569238db68597/lookandfeel/contents/components/ActionButton.qml#L33 the mouseover animation uses PropertyAnimation, and says in a comment that OpacityAnimator is buggy. But in LogoutButton.qml https://github.com/KDE/plasma-workspace/blob/91909b577045b2e347033a557d0569238db68597/lookandfeel/contents/logout/LogoutButton.qml#L27 the mouseover animation is still using OpacityAnimator. Changing it to PropertyAnimation fixes the bug for me.