Bug 445952

Summary: Tools Area appearance not used for tab bar and menubar in Thunderbird and Firefox
Product: [Plasma] Breeze Reporter: Grzesiek11 <grzesiek11>
Component: gtk themeAssignee: Janet Blackquill <uhhadd>
Status: RESOLVED FIXED    
Severity: normal CC: ivan, nate, plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.23.3   
Target Milestone: ---   
Platform: Debian unstable   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/breeze-gtk/commit/90c9a9d40f298186e1b9072701b3a8383f980d45 Version Fixed In: 5.25
Sentry Crash Report:

Description Grzesiek11 2021-11-23 00:46:33 UTC 
SUMMARY
In GTK programs like Inkscape, Thunderbird, Chromium, Firefox, VSCodium and others the header/toolbar has a different color to the window bar, which looks pretty ugly.
With Breeze Dark color scheme it's #31363b for the window bar and #2a2e32 for the header. With Breeze Light it's #dee0e2 and #eff0f1 instead.
This is a regression, but I don't know the version it stopped working correctly.

STEPS TO REPRODUCE
1. Launch any of the mentioned GTK programs.
2. Compare the color between the window bar and the program header.

OBSERVED RESULT
The color is different.

EXPECTED RESULT
The color is the same.

SOFTWARE/OS VERSIONS
Operating System: Debian GNU/Linux
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.2
Kernel Version: 5.15.0-3.2-liquorix-amd64 (64-bit)
Graphics Platform: X11
Processors: 4 × Intel® Core™ i5-2400 CPU @ 3.10GHz
Memory: 11.7 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 660/PCIe/SSE2

ADDITIONAL INFORMATION
Screenshots (how it looks like):
- Chromium: https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211123_004101.png
- Thunderbird: https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211123_004125.png
- VSCodium: https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211123_004135.png
- Inkscape (this one is a bit special, since the header actually goes around the entire window): https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211123_004525.png

Edited screenshots (how it should look like):
- Chromium: https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211123_004101_improved.png
- Thunderbird: https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211123_004125_improved.png
- VSCodium: https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211123_004135_improved.png
- Inkscape: https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211123_004525_improved.png
Comment 1 Iván Ávalos 2022-02-06 10:26:11 UTC 
I can reproduce. This issue has been present for a long time indeed. I hope it gets fixed in 5.24, or else I'll die.
Comment 2 Nate Graham 2022-02-07 16:52:30 UTC 
Unfortunately these are all different bugs.

- The issue in Inkscape is Bug 448941
- The issue Chromium is Bug 435224
- The issue in VSCodium is not a Breeze-GTK bug since it is an Electron app and does not respect the KDE color scheme at all, and there is no way we can hack this in.
- The issue in Thunderbird is not tracked anywhere, so let's use this for that.
Comment 3 Nate Graham 2022-02-07 16:53:29 UTC 
> I hope it gets fixed in 5.24, or else I'll die.
Something tells me you'll find a way to keep on living despite this minor visual glitch not being fixed in Plasma 5.24 which is releasing in two days. :)
Comment 4 Grzesiek11 2022-02-07 17:21:19 UTC 
(In reply to Nate Graham from comment #2)
> - The issue in VSCodium is not a Breeze-GTK bug since it is an Electron app
> and does not respect the KDE color scheme at all, and there is no way we can
> hack this in.

Electron still uses GTK for the window stuff like rightclick menus or the mentioned header. Electron apps can hide these elements and use browser-rendered ones instead, but VSCodium (and AFAIK VSCode too) chooses not to.
Comment 5 Nate Graham 2022-02-07 17:59:10 UTC 
OK, can you file a new bug reports about the issue with menubars in Electron apps?
Comment 6 Grzesiek11 2022-02-07 20:32:54 UTC 
(In reply to Nate Graham from comment #5)
> OK, can you file a new bug reports about the issue with menubars in Electron
> apps?

Done: Bug 449759.
Comment 7 Nate Graham 2022-05-10 21:12:14 UTC 
Git commit 90c9a9d40f298186e1b9072701b3a8383f980d45 by Nate Graham, on behalf of Artem Grinev.
Committed on 10/05/2022 at 21:12.
Pushed by ngraham into branch 'master'.

gtk3,gtk4: Use Header colors for menubars

Applying this to toolbars will require additional research and maybe app-specific
hacks, as GTK uses toolbars for more than just window headers.
Related: bug 449759, bug 448941
FIXED-IN: 5.25

M  +2    -2    src/gtk3/widgets/_menus.scss
M  +2    -2    src/gtk4/widgets/_menus.scss

https://invent.kde.org/plasma/breeze-gtk/commit/90c9a9d40f298186e1b9072701b3a8383f980d45