Summary: | Applications list in 'Overview' page is empty after opening/closing 'Configure columns...' | ||
---|---|---|---|
Product: | [Applications] plasma-systemmonitor | Reporter: | Patrick Silva <bugseforuns> |
Component: | general | Assignee: | KSysGuard Developers <ksysguard-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ahiemstra, kde, nate, plasma-bugs |
Priority: | NOR | ||
Version: | master | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-systemmonitor/commit/50f6378144ed244b9c1cd3e325ecbe45dd7544d4 | Version Fixed In: | 5.23.4 |
Sentry Crash Report: | |||
Attachments: | screen recording |
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/172 Git commit a96bc99a3650c3bf2e48ab1287dc779dbba87c51 by David Redondo. Committed on 02/12/2021 at 14:51. Pushed by davidre into branch 'master'. ApplicationsTable: Remove unneeded ProcessSortFilterModel ProcessSortFilterModel handles filtering pids and to which user a process belongs over a normal QSortFilterProxyModel. In doing so it also sets the filterKeyColumn to nameColumn in findColumns(). Note that the name of the name columns of the process and application table is different ("name" and "appName"), so the filterKeyColumn is also set by ApplicationTableView. However this is racey depending on when the binding is evaluated. Since we don't need the extra features of the ProcessSortFilterModel we can use the existing SortFilterProxyModel in charge of filtering columns (something that the ProcessSortFilterModel also did) to also handle the row filtering. FIXED-IN:5.23.4 M +4 -11 src/faces/applicationstable/contents/ui/ApplicationsTableView.qml https://invent.kde.org/plasma/plasma-systemmonitor/commit/a96bc99a3650c3bf2e48ab1287dc779dbba87c51 Git commit 50f6378144ed244b9c1cd3e325ecbe45dd7544d4 by David Redondo. Committed on 02/12/2021 at 14:54. Pushed by davidre into branch 'Plasma/5.23'. ApplicationsTable: Remove unneeded ProcessSortFilterModel ProcessSortFilterModel handles filtering pids and to which user a process belongs over a normal QSortFilterProxyModel. In doing so it also sets the filterKeyColumn to nameColumn in findColumns(). Note that the name of the name columns of the process and application table is different ("name" and "appName"), so the filterKeyColumn is also set by ApplicationTableView. However this is racey depending on when the binding is evaluated. Since we don't need the extra features of the ProcessSortFilterModel we can use the existing SortFilterProxyModel in charge of filtering columns (something that the ProcessSortFilterModel also did) to also handle the row filtering. FIXED-IN:5.23.4 (cherry picked from commit a96bc99a3650c3bf2e48ab1287dc779dbba87c51) M +4 -11 src/faces/applicationstable/contents/ui/ApplicationsTableView.qml https://invent.kde.org/plasma/plasma-systemmonitor/commit/50f6378144ed244b9c1cd3e325ecbe45dd7544d4 |
Created attachment 143594 [details] screen recording SUMMARY Summary says it all. Please watch the attached screen recording. EXPECTED RESULT observed result should not occur. SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.23.80 KDE Frameworks Version: 5.89.0 Qt Version: 5.15.3 Graphics Platform: X11