| Summary: | Visual bell unreliable in latest version | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | davidblunkett <dav1dblunk3tt> |
| Component: | general | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gi1242+kde |
| Priority: | NOR | ||
| Version: | 21.11.80 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=455554 | ||
| Latest Commit: | https://invent.kde.org/utilities/konsole/commit/2f2ae3d9bb8a44fa987c10cc4b2a9018d34f300b | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | screenshot | ||
|
Description
davidblunkett
2021-11-15 10:44:18 UTC
I think the problem is a regression between versions 21.08.3-1 and 21.11.80-1 (and is still present in 21.12.0-1).
Simple test: Run
echo -n "\e]11;#004000\a"
In other terminal emulators (xterm), and konsole 21.08.3-1 and earlier, the background goes green. In Konsole 21.11.80-1 and later the background goes green only after a redraw.
My guess is that the visual bell bug is related to this, and there is a bug (regression) in the background refresh.
I'm using Arch linux.
GI
I think the problem is a regression between versions 21.08.3-1 and 21.11.80-1 (and is still present in 21.12.0-1).
Simple test: Run
echo -n "\e]11;#004000\a"
In other terminal emulators (xterm), and konsole 21.08.3-1 and earlier, the background goes green. In Konsole 21.11.80-1 and later the background goes green only after a redraw.
My guess is that the visual bell bug is related to this, and there is a bug (regression) in the background refresh.
I'm using Arch linux.
GI
PS: I couldn't figure out how to mark it as a regression. So I just set component to general, and marked it as confirmed.
A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/573 Git commit 0fe44c52310a6c276388cf30c81b6fc45a39da32 by Kurt Hindenburg, on behalf of Luis Javier Merino Morán. Committed on 11/01/2022 at 15:57. Pushed by hindenburg into branch 'master'. Pass widget again to KNotification on bell 67508680 refactored TerminalBell out from TerminalDisplay, and in the process stopped passing the TerminalDisplay widget to KNotification, which resulted in issues when notifications where configured to mark the task bar entry or run a command with %w/%t substitutions (for window id and window title). Many thanks to Nicole Kleinhoff and Jan Palus who identified the commit that introduced the regression. Related: bug 443411, bug 443117 M +3 -2 src/terminalDisplay/TerminalBell.cpp M +2 -1 src/terminalDisplay/TerminalBell.h M +1 -1 src/terminalDisplay/TerminalDisplay.cpp https://invent.kde.org/utilities/konsole/commit/0fe44c52310a6c276388cf30c81b6fc45a39da32 This doesn't fix the problem for me! Simple test: 1. Enalble Visual Bell 2. Type 'echo -e "\a" ' into a shell Display is borked for me (half white half black). I can share a screen cast if you can't reproduce it. Created attachment 145341 [details]
screenshot
A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/579 Git commit 2f2ae3d9bb8a44fa987c10cc4b2a9018d34f300b by Luis Javier Merino Morán. Committed on 12/01/2022 at 16:19. Pushed by hindenburg into branch 'master'. Fix visual bell Changes to scrollbar colouring interfered with the visual bell. TerminalColor::onColorsChanged() not only updates the scrollbar palette (for Breeze widget style), but also updates the TerminalDisplay palette. M +6 -0 src/terminalDisplay/TerminalColor.cpp https://invent.kde.org/utilities/konsole/commit/2f2ae3d9bb8a44fa987c10cc4b2a9018d34f300b |