| Summary: | KDE Plasma doesn't respect icon theme for some applications and application icons | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] libplasma | Reporter: | Nick Stefanov <mo78> |
| Component: | components | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 2wxsy58236r3, abyss.7, dobey.pwns, jan.rathmann, KDE, mo78, nate, plasma-bugs, RaitaroHikami, smitha, till2.schaefer |
| Priority: | NOR | ||
| Version: | 5.88.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=445489 https://bugs.kde.org/show_bug.cgi?id=445685 https://bugs.kde.org/show_bug.cgi?id=445756 https://bugs.kde.org/show_bug.cgi?id=438191 |
||
| Latest Commit: | Version Fixed In: | 6.0 | |
| Attachments: |
uGet screenshot
List of files and directories which are present only in 5.87.0 (vs 5.88.0 + PR 171 / 5893bcff) breeze-icons build log Wrong/weird folder icons with Breeze-Dark on Ubuntu Jammy |
||
|
Description
Nick Stefanov
2021-11-15 10:05:49 UTC
I can confirm this for Krusader - I use Breeze Dark, yet Krusader now uses the light theme (making the toolbar icons very hard to see), Downgrading breeze-icons to 5.87 fixes the issue. it affects multiple applications, even Kate. For example the close button is from Breeze theme, other are from my icon theme. It even changed many application shortcuts and panel icons. It's a serious problem. Devs, do you need more info or something? What's this silence, it's a very serious problem! an confirm the issue with light theme icons in Krusader while dark theme is selected. Operating System: Gentoo Linux KDE Plasma Version: 5.23.3 KDE Frameworks Version: 5.88.0 Qt Version: 5.15.2 Kernel Version: 5.14.20-gentoo (64-bit) Graphics Platform: Wayland Processors: 8 × Intel® Core™ i7-4810MQ CPU @ 2.80GHz Memory: 15.5 GiB of RAM Graphics Processor: Mesa DRI Intel® HD Graphics 4600 Created attachment 143856 [details] uGet screenshot Even if I apply [this breeze-icons patch](https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/171), the bug is still present. Icons look fine after downgrading breeze-icons to 5.87.0. In the attached uGet screenshot: - Upper half is KDE Frameworks 5.88.0 + breeze-icons 5.87.0 - Lower half is KDE Frameworks 5.88.0 + patched breeze-icons 5.88.0 And even if you change the icon for an application, the panel icon doesn't change and it is breeze. It even doesn't respect some app icons in the system tray. Please tell us what additional info do you need. I found the problem. I opened another bug under the right component: https://bugs.kde.org/show_bug.cgi?id=446253 Can you confirm? Yes, they are identical but I don't use Breeze icons at all. Nevertheless the system is using them all around... Just removing the breeze-icon package solves this weird problem. Thank you for the heads up! Created attachment 144106 [details]
List of files and directories which are present only in 5.87.0 (vs 5.88.0 + PR 171 / 5893bcff)
I applied the latest revision of PR 171 on 5.88.0, and then I tried to compare both versions.
From attachment 144106 [details], it seems that the size 24 icons are missing in the patched 5.88.0?
@dobey
Do you have any idea?
(In reply to 2wxsy58236r3 from comment #12) > I applied the latest revision of PR 171 on 5.88.0, and then I tried to > compare both versions. > > From attachment 144106 [details], it seems that the size 24 icons are > missing in the patched 5.88.0? > > @dobey > Do you have any idea? The 24px icons are all installed for me in my testing here. Did you build it without python3 or lxml available? Or on Windows? Created attachment 144136 [details] breeze-icons build log (In reply to Rodney Dawes from comment #13) > The 24px icons are all installed for me in my testing here. Did you build it > without python3 or lxml available? Or on Windows? I built the package locally (and also on Open Build Service [1]), with Arch Linux. python-lxml is installed. I have attached the build log. There are many lines starting with `-- Installing: /usr/share/icons/breeze-dark/actions/24/`, so it looks like the 24px dark icons are generated but for unknown reason the result package does not have them. I am using the PKGBUILD from Arch Linux [2] and the only modification is to include and apply the patch. [1] https://build.opensuse.org [2] https://raw.githubusercontent.com/archlinux/svntogit-packages/packages/breeze-icons/trunk/PKGBUILD (In reply to 2wxsy58236r3 from comment #14) > Created attachment 144136 [details] > breeze-icons build log > > (In reply to Rodney Dawes from comment #13) > > The 24px icons are all installed for me in my testing here. Did you build it > > without python3 or lxml available? Or on Windows? > > I built the package locally (and also on Open Build Service [1]), with Arch > Linux. python-lxml is installed. > > I have attached the build log. There are many lines starting with `-- > Installing: /usr/share/icons/breeze-dark/actions/24/`, so it looks like the > 24px dark icons are generated but for unknown reason the result package does > not have them. How exactly is DESTDIR being set in this scenario? OK. I've recreated the problem, and updated the 171 PR to address the issue as it seems `DESTDIR=foo cmake --install build` results in the `$ENV{DESTDIR}` in the install script not being interpreted properly. Escaping as `\$ENV{}` seems to solve the issue here, so 171 should be good in this case now.
Created attachment 144286 [details]
Wrong/weird folder icons with Breeze-Dark on Ubuntu Jammy
Can confirm for Kubuntu 21.10 with Backports-PPA and breeze-icon-theme 4:5.88.0-0ubuntu1~ubuntu21.10~ppa1. On Kubuntu Jammy with breeze-icon-theme 4:5.88.0-2ubuntu1 I don't see this bug (it goes away on 21.10 too if I download breeze-icon-theme_5.88.0-2ubuntu1_all.deb from Jammy and install it manually). But I get "wrong/weird" folder icons with Breeze-Dark with 4:5.88.0-2ubuntu1 installed, so that's unfortunately not a good workaround. This should be fixed now on breeze-icons master branch I think. Plasma 5.24 - the bug is still here. Plasma 5.24.2 - The bug is still here. Plasma 5.24.3 - The bug is still here. Plasma 5.24.4 Plasma 5.24.4 - The bug is still here. Plasma 5.24.5 - The bug is still here. Plasma 5.25 - The bug is still here. This is kinda serious problem. How longer will it take to realize that? Plasma 5.25.2 - The problem is still here. Plasma 5.26 - The problem is still here. Plasma 5.26.2 - The problem is still here. Plasma 5.27 Beta - the bug is still here. The only solution is to uninstall breeze-icons package. Plasma 5.27.1 - the bug is still here. Plasma 5.27.2 - the bug is still here. It seems nobody cares. From now on breeze-icons is in the ignor list forever on my pacman.conf. Thank you for your time. This is fixed for Plasma 6 by always using icons from the Icon theme, never from the Plasma theme. |