Bug 444343

Summary: After replacing kickoff with classic kickoff, it does not open with the Meta key
Product: [Plasma] plasmashell Reporter: David <david.cortes.rivera>
Component: generalAssignee: David Edmundson <kde>
Status: RESOLVED FIXED    
Severity: normal CC: katyaberezyaka, nate, plasma-bugs, postix
Priority: NOR    
Version: 5.23.0   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=447962
https://bugs.kde.org/show_bug.cgi?id=391322
Latest Commit: Version Fixed In: 5.26
Sentry Crash Report:

Description David 2021-10-24 19:50:53 UTC
SUMMARY
If I install the "Legacy Application Launcher" which was removed from KDE and set it as my application launcher in a panel, it will not be triggered by the "meta" (windows) key.

STEPS TO REPRODUCE
1. Install the legacy application launcher which used to be the default in KDE 5.21 or so.
2. Right-click the new applicaton launcher, select "Switch Alternatives...", and set the previous application launcher to be used.
3. Press "meta" (windows key).

OBSERVED RESULT
Nothing happens.

EXPECTED RESULT
Should open the application launcher.

SOFTWARE/OS VERSIONS
Operating System: Debian GNU/Linux
KDE Plasma Version: 5.23.0
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.2
Kernel Version: 5.14.0-3-amd64 (64-bit)
Graphics Platform: X11
Processors: 16 × AMD Ryzen 7 2700 Eight-Core Processor
Memory: 15.5 GiB of RAM
Graphics Processor: AMD VEGA10

ADDITIONAL INFORMATION
Comment 1 David 2021-10-24 19:56:47 UTC
And BTW this would solve it: https://forum.manjaro.org/t/kde-application-launcher-doesnt-open-when-meta-key-is-pressed/34257/11

But it seems that configuration change is not being done automatically by KDE.
Comment 2 Nate Graham 2021-10-25 21:26:39 UTC
Does the applet get the default Alt+F1 shortcut applied in its settings window, or is the shortcut empty there?
Comment 3 David 2021-10-25 22:37:41 UTC
(In reply to Nate Graham from comment #2)
> Does the applet get the default Alt+F1 shortcut applied in its settings
> window, or is the shortcut empty there?

It did have the shortcut, and nothing changed by removing it.
Comment 4 Nate Graham 2021-10-25 22:39:56 UTC
OK, then this may be an issue in KWin with how it detects the applet to assign it the meta key.

Does it open if you hit Alt+F1 (or whatever the shortcut is listed as in the settings window)?
Comment 5 David 2021-10-25 22:45:04 UTC
(In reply to Nate Graham from comment #4)
> OK, then this may be an issue in KWin with how it detects the applet to
> assign it the meta key.
> 
> Does it open if you hit Alt+F1 (or whatever the shortcut is listed as in the
> settings window)?

It did open with Alt+F1, and would also open with a different shortcut if I change it, but the default one opened with "meta".

Also BTW would be better if it had a checkbox right there to make it open with "meta", as otherwise one tries to set that as a shortcut but it does not take it as a single key, which is confusing, and the kwin trick is not even available in the system settings.
Comment 6 David 2021-11-19 18:42:16 UTC
(In reply to Nate Graham from comment #4)
> OK, then this may be an issue in KWin with how it detects the applet to
> assign it the meta key.
> 
> Does it open if you hit Alt+F1 (or whatever the shortcut is listed as in the
> settings window)?

Another issue: after using the workaround to make the launcher menu open with Meta, now krunner does not open with ctrl+space anymore.
Comment 7 David 2021-11-19 18:42:33 UTC
(In reply to David from comment #6)
> (In reply to Nate Graham from comment #4)
> > OK, then this may be an issue in KWin with how it detects the applet to
> > assign it the meta key.
> > 
> > Does it open if you hit Alt+F1 (or whatever the shortcut is listed as in the
> > settings window)?
> 
> Another issue: after using the workaround to make the launcher menu open
> with Meta, now krunner does not open with ctrl+space anymore.

EDIT: alt+space.
Comment 8 Bug Janitor Service 2022-07-20 13:43:31 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1937
Comment 9 Nate Graham 2022-08-04 16:41:05 UTC
Git commit 40d6e18b0f153464a64b3e21c1224e13511632d2 by Nate Graham, on behalf of David Redondo.
Committed on 04/08/2022 at 16:23.
Pushed by ngraham into branch 'master'.

Take active screen in account and remove shortcut requirement for activating launcher

With the information about the active screen we can make an educated
guess about where the attention of the user is and where they could
expect the launcher to open. If on the screen no launcher could be
activated, look at all launchers. Also remove the requirement for
launchers to have a shortcut. This is needed to make this feature
work reliably and should reduce the instances of "Meta key stopped working"
happening in general.
Related: bug 391322, bug 437979, bug 447962

M  +29   -9    shell/shellcorona.cpp
M  +1    -0    shell/shellcorona.h

https://invent.kde.org/plasma/plasma-workspace/commit/40d6e18b0f153464a64b3e21c1224e13511632d2