| Summary: | "Decoration" items in Breeze-light (and Breeze-dark) "color" file redundant an faulty | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | PK <pieterkristensen> |
| Component: | Color scheme | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version: | 5.23.1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Breeze-dark theme with the orriginal "colors" file in the theme
Breeze-dark blends in with system accent colors explanation of the light-blue accents orrignal breeze-dark colors-file stripped down version of the "colors" file |
||
|
Description
PK
2021-10-23 06:55:04 UTC
Can you please: 1.attach a screenshot that shows the problem 2. Attach the faulty color scheme in questioin 3. Mention the exact paths of the color scheme and the fallback you're referring to Created attachment 142890 [details]
Breeze-dark theme with the orriginal "colors" file in the theme
The systemsettings color-module is also to be seen. I am using a color-scheme with orange accent-color as you can see
Created attachment 142891 [details]
Breeze-dark blends in with system accent colors
To achieve this situation I copied the folder /usr/share/plasma/desktoptheme/breeze-dark to the ~/local/share/plasma/desktoptheme folder, then I opened the colors-file with Kate and "search-and-replaced" all instances of "Decoration" with "#Decoration" automatically.
There are 16 items replaced. The result looks good.
Created attachment 142892 [details]
explanation of the light-blue accents
Kcolorchooser shows the color that the "Decorations" are originally set to.
You can just leave away information in a plasma-theme. KDE fills in the holes by using the theme "default". This theme is also found in the folder /usr/share/plasma/desktoptheme. In my opinion the theme "default" is a masterpiece that functions as a safety net... Created attachment 142893 [details]
orrignal breeze-dark colors-file
This file is located in the folder /usr/share/plasma/desktoptheme/breeze-dark. The user can overwrite it by putting it in his own folder ~/.local/share/plasma/desktoptheme/breeze-dark and changing it.
Thanks. I am still a little bit unsure what the problem is, exactly. What default color scheme is it falling back to? I would expect that the Plasma-themes "Breeze-light" and "Breeze-dark" would just be as beautiful and refined as the "Breeze" Plasma theme only without the panel following the system-colors automatically (dark/light). This turns out to be not the case. Not only do the panels stay dark or light (good) but the decoration color in the panel is fixed too! I my opinion that is an unnecessary deterioration. Of course I am not 100% sure of what I say about the fall-back. But after some searching I found out that commenting out the "Decoration" items in the "colors" files of the Plasma-themes Breeze-light and Breeze-dark had a good effect. (as far as the "default" thing concerns: I created a folder "experiment" in my folder ~/.local/share/plasma/desktoptheme and copied and paste in the file metadata-desktop from another plasma-theme. I added nothing else to the newly made plasma-theme folder. In this theme "experiment" I changed the line "X-KDE-PluginInfo-Name=orriginal-name" in the file "metadata-desktop" to "X-KDE-PluginInfo-Name=experiment". The theme "experiment" shows up in the systemsettings. And, as I expected, it is an exact copy of het Breeze Plasma-theme. This is, I think, because the default Plasma-theme fills in the holes) Now I am looking at your comment 7 and I feel I perhaps could be clearer. Plasma-themes bring with them their own icons, panels, etc etc. They also bring with them a file (located in the folder of the plasma-theme) "colors". In this file lays down what colors the plasma-theme uses. If one of all components (or parts there off) is missing, this missing part is filled in from the "default" plasma theme (/usr/share/plasma/desktoptheme/default). This "default" plasma-theme manifests itself to us under the name of "Breeze". And the Breeze plasma-theme (or the default theme if you want) has as specialty that is adapts to the current system-colors. So when the Breeze-light plasma theme doesen't specify decoration-colors in its "color" file the "default" plasma theme takes care of this missing colors. And the "default" plasma theme follows system-colors. Ah I get it now. *** This bug has been marked as a duplicate of bug 444043 *** Created attachment 143138 [details]
stripped down version of the "colors" file
I "commented out" some more of the values in the "colors" file of the Breeze-dark plasma-theme and imho it made the theme only better...
Please feel free to submit a merge request to change that! People are eager to see Bug 444043 fixed. |